Bug 179730 - [WPE] Expose ENABLE_JIT and USE_SYSTEM_MALLOC options
Summary: [WPE] Expose ENABLE_JIT and USE_SYSTEM_MALLOC options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 178894
  Show dependency treegraph
 
Reported: 2017-11-15 07:14 PST by Michael Catanzaro
Modified: 2017-11-16 11:07 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2017-11-15 07:15 PST, Michael Catanzaro
clopez: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.42 MB, application/zip)
2017-11-15 08:34 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-11-15 07:14:34 PST
ENABLE_JIT and USE_SYSTEM_MALLOC are both required to build on various platforms... pretty much everything that's not x86 or ARM. So let's expose them.
Comment 1 Michael Catanzaro 2017-11-15 07:15:10 PST
Created attachment 326981 [details]
Patch
Comment 2 Build Bot 2017-11-15 08:34:39 PST
Comment on attachment 326981 [details]
Patch

Attachment 326981 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5246368

New failing tests:
http/tests/security/import-module-crossorigin-loads-error-src.html
Comment 3 Build Bot 2017-11-15 08:34:40 PST
Created attachment 326985 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 WebKit Commit Bot 2017-11-16 09:43:51 PST
Comment on attachment 326981 [details]
Patch

Rejecting attachment 326981 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 326981, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
eviewer', u'Carlos Alberto Lopez Perez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/cmake/OptionsWPE.cmake
Hunk #1 FAILED at 15.
1 out of 1 hunk FAILED -- saving rejects to file Source/cmake/OptionsWPE.cmake.rej
patching file ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Alberto Lopez Perez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5260300
Comment 5 Michael Catanzaro 2017-11-16 11:07:42 PST
Committed r224926: <https://trac.webkit.org/changeset/224926>