Bug 179716 - Remove GTK web inspector images
Summary: Remove GTK web inspector images
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Keywords: InRadar
Depends on:
Reported: 2017-11-14 20:20 PST by Michael Catanzaro
Modified: 2017-11-17 10:46 PST (History)
7 users (show)

See Also:

Patch (725.23 KB, patch)
2017-11-14 20:35 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Screenshot (149.90 KB, image/png)
2017-11-14 20:39 PST, Michael Catanzaro
no flags Details
Patch (726.77 KB, patch)
2017-11-15 08:32 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-11-14 20:20:04 PST
Now that bug #166460 is resolved, we no longer need a separate set of web inspector images for non-Apple ports.
Comment 1 Michael Catanzaro 2017-11-14 20:35:59 PST
Created attachment 326964 [details]
Comment 2 Michael Catanzaro 2017-11-14 20:39:31 PST
Created attachment 326965 [details]

The Apple icons also better match the look and feel of the web inspector.
Comment 3 Michael Catanzaro 2017-11-15 08:32:25 PST
Created attachment 326984 [details]
Comment 4 Michael Catanzaro 2017-11-15 08:56:59 PST
Committed r224877: <https://trac.webkit.org/changeset/224877>
Comment 5 Radar WebKit Bug Importer 2017-11-15 09:31:14 PST
Comment 6 Joseph Pecoraro 2017-11-17 10:46:28 PST
Great! There are a few places in CSS we might be able to remove now. For example:

> /* FIXME: <https://webkit.org/b/155282> [GTK] Web Inspector: Add new GTK+ icons for different Heap Allocations Timeline Views (Heap Snapshots) */
> body:not(.mac-platform, .windows-platform) .heap-snapshot-record .icon,
> body:not(.mac-platform, .windows-platform) .heap-snapshot-summary-icon .icon,
> body:not(.mac-platform, .windows-platform) .heap-snapshot-instances-icon .icon,
> body:not(.mac-platform, .windows-platform) .snapshot-diff-icon .icon {
>     content: url(../Images/ResultLine.svg);
> }

I'll take a look today.