Bug 179620 - Don't eliminate whitespace renderer if the previous sibling is a text renderer
Summary: Don't eliminate whitespace renderer if the previous sibling is a text renderer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 157477
  Show dependency treegraph
 
Reported: 2017-11-13 10:59 PST by Antti Koivisto
Modified: 2017-11-13 15:39 PST (History)
6 users (show)

See Also:


Attachments
patch (5.05 KB, patch)
2017-11-13 11:40 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (5.12 KB, patch)
2017-11-13 11:42 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-11-13 10:59:26 PST
Currently whitespace elimination code doesn't consider runs of text renderers. We should always make whitespace renderer if the previous renderer is a text renderer. The behavior should be the same as if those were a single renderer with merged text. This situation can happen easily with display:contents.
Comment 1 Antti Koivisto 2017-11-13 11:40:35 PST
Created attachment 326777 [details]
patch
Comment 2 Antti Koivisto 2017-11-13 11:42:29 PST
Created attachment 326778 [details]
patch
Comment 3 WebKit Commit Bot 2017-11-13 13:14:50 PST
Comment on attachment 326778 [details]
patch

Clearing flags on attachment: 326778

Committed r224773: <https://trac.webkit.org/changeset/224773>
Comment 4 WebKit Commit Bot 2017-11-13 13:14:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-13 15:39:52 PST
<rdar://problem/35517807>