Bug 179469 – [WinCairo EWS] svn-apply: 'cp' is not recognized as an internal or external command

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Fujii Hironori]

[WinCairo EWS] svn-apply: 'cp' is not recognized as an internal or external command,

WinCairo EWS hasn't installed Cygwin.

https://webkit-queues.webkit.org/patch/326404/wincairo-ews

> Failed to run "['python', 'C:\\WebKit-EWS\\WebKit\\Tools\\Scripts\\webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=wincairo-ews-002', 'apply-attachment', '--no-update', '--non-interactive', 326404, '--port=wincairo']" exit_code: 2 cwd: C:/WebKit-EWS/WebKit
> 
> Logging in as [e-mail]...
> Fetching: https://bugs.webkit.org/attachment.cgi?id=326404&action=edit
> Fetching: https://bugs.webkit.org/show_bug.cgi?id=179457&ctype=xml&excludefield=attachmentdata
> Processing 1 patch from 1 bug.
> Processing patch 326404 from bug 179457.
> Failed to run "['perl', u'C:/WebKit-EWS/WebKit\\Tools\\Scripts\\svn-apply', '--force']" exit_code: 2 cwd: C:/WebKit-EWS/WebKit
> 
> Parsed 39 diffs from patch file(s).
> 
> 'cp' is not recognized as an internal or external command,
> 
> operable program or batch file.
> 
> Failed to copy Source/JavaScriptCore/inspector/scripts/tests/generic/fail-on-domain-availability.json Source/JavaScriptCore/inspector/scripts/tests/generic/fail-on-domain-availability-type.json. at C:/WebKit-EWS/WebKit\Tools\Scripts\svn-apply line 447.
> 
> 
> Failed to run "['perl', u'C:/WebKit-EWS/WebKit\\Tools\\Scripts\\svn-apply', '--force']" exit_code: 2 cwd: C:/WebKit-EWS/WebKit

[Fujii Hironori]

Created attachment 326435 [details]
Patch

[Fujii Hironori]

Created attachment 326436 [details]
Patch

[Per Arne Vollan]

Comment on attachment 326436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326436&action=review

> Tools/Scripts/svn-apply:65
> +use File::Copy qw(copy);

Does this module exist on all platforms?

[Don Olmstead]

(In reply to Per Arne Vollan from comment #3)
> Comment on attachment 326436 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326436&action=review
> 
> > Tools/Scripts/svn-apply:65
> > +use File::Copy qw(copy);
> 
> Does this module exist on all platforms?

https://perldoc.perl.org/index-modules-F.html says its in the standard libraries. Also File:: is used above

[Stephan Szabo]

Looks like it's part of the standard install modules (from search.cpan.org's results looks like it's been part since at least 5.8.0) and appears to exist in standard installation on Windows and Ubuntu.

[Per Arne Vollan]

Comment on attachment 326436 [details]
Patch

R=me. We'll keep an eye on the bots after this lands.

[WebKit Commit Bot]

Comment on attachment 326436 [details]
Patch

Clearing flags on attachment: 326436

Committed r224647: <https://trac.webkit.org/changeset/224647>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35562106>