Bug 179469 - [WinCairo EWS] svn-apply: 'cp' is not recognized as an internal or external command
Summary: [WinCairo EWS] svn-apply: 'cp' is not recognized as an internal or external c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-09 01:21 PST by Fujii Hironori
Modified: 2017-11-15 09:38 PST (History)
9 users (show)

See Also:


Attachments
Patch (1.61 KB, patch)
2017-11-09 01:33 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2017-11-09 01:36 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2017-11-09 01:21:51 PST
[WinCairo EWS] svn-apply: 'cp' is not recognized as an internal or external command,

WinCairo EWS hasn't installed Cygwin.

https://webkit-queues.webkit.org/patch/326404/wincairo-ews

> Failed to run "['python', 'C:\\WebKit-EWS\\WebKit\\Tools\\Scripts\\webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=wincairo-ews-002', 'apply-attachment', '--no-update', '--non-interactive', 326404, '--port=wincairo']" exit_code: 2 cwd: C:/WebKit-EWS/WebKit
> 
> Logging in as SIE-WebKit-EWS@am.sony.com...
> Fetching: https://bugs.webkit.org/attachment.cgi?id=326404&action=edit
> Fetching: https://bugs.webkit.org/show_bug.cgi?id=179457&ctype=xml&excludefield=attachmentdata
> Processing 1 patch from 1 bug.
> Processing patch 326404 from bug 179457.
> Failed to run "['perl', u'C:/WebKit-EWS/WebKit\\Tools\\Scripts\\svn-apply', '--force']" exit_code: 2 cwd: C:/WebKit-EWS/WebKit
> 
> Parsed 39 diffs from patch file(s).
> 
> 'cp' is not recognized as an internal or external command,
> 
> operable program or batch file.
> 
> Failed to copy Source/JavaScriptCore/inspector/scripts/tests/generic/fail-on-domain-availability.json Source/JavaScriptCore/inspector/scripts/tests/generic/fail-on-domain-availability-type.json. at C:/WebKit-EWS/WebKit\Tools\Scripts\svn-apply line 447.
> 
> 
> Failed to run "['perl', u'C:/WebKit-EWS/WebKit\\Tools\\Scripts\\svn-apply', '--force']" exit_code: 2 cwd: C:/WebKit-EWS/WebKit
Comment 1 Fujii Hironori 2017-11-09 01:33:57 PST
Created attachment 326435 [details]
Patch
Comment 2 Fujii Hironori 2017-11-09 01:36:39 PST
Created attachment 326436 [details]
Patch
Comment 3 Per Arne Vollan 2017-11-09 12:30:57 PST
Comment on attachment 326436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326436&action=review

> Tools/Scripts/svn-apply:65
> +use File::Copy qw(copy);

Does this module exist on all platforms?
Comment 4 Don Olmstead 2017-11-09 12:35:42 PST
(In reply to Per Arne Vollan from comment #3)
> Comment on attachment 326436 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326436&action=review
> 
> > Tools/Scripts/svn-apply:65
> > +use File::Copy qw(copy);
> 
> Does this module exist on all platforms?

https://perldoc.perl.org/index-modules-F.html says its in the standard libraries. Also File:: is used above
Comment 5 Stephan Szabo 2017-11-09 13:05:43 PST
Looks like it's part of the standard install modules (from search.cpan.org's results looks like it's been part since at least 5.8.0) and appears to exist in standard installation on Windows and Ubuntu.
Comment 6 Per Arne Vollan 2017-11-09 13:51:37 PST
Comment on attachment 326436 [details]
Patch

R=me. We'll keep an eye on the bots after this lands.
Comment 7 WebKit Commit Bot 2017-11-09 14:13:19 PST
Comment on attachment 326436 [details]
Patch

Clearing flags on attachment: 326436

Committed r224647: <https://trac.webkit.org/changeset/224647>
Comment 8 WebKit Commit Bot 2017-11-09 14:13:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-11-15 09:38:01 PST
<rdar://problem/35562106>