Bug 179457 - Web Inspector: Make domain availability a list of types instead of a single type
Summary: Web Inspector: Make domain availability a list of types instead of a single type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-08 16:40 PST by Joseph Pecoraro
Modified: 2017-11-15 09:38 PST (History)
10 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (99.08 KB, patch)
2017-11-08 16:45 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-11-08 16:40:58 PST
Make domain availability a list of types instead of a single type

The intent of this change is to make it so the Network domain will be available in both a "web" and "service-worker" domain but not a "javascript" domain.

This changes:

    InspectorBackend.activateDomain("Network", "web");

to:

    InspectorBackend.activateDomain("Network", ["web"]);

And later we will be able to do:

    InspectorBackend.activateDomain("Network", ["web", "service-worker"]);
Comment 1 Joseph Pecoraro 2017-11-08 16:45:51 PST
Created attachment 326404 [details]
[PATCH] Proposed Fix
Comment 2 Build Bot 2017-11-08 16:47:38 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 BJ Burg 2017-11-09 10:11:16 PST
Comment on attachment 326404 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2017-11-09 10:32:30 PST
Comment on attachment 326404 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 326404

Committed r224634: <https://trac.webkit.org/changeset/224634>
Comment 5 WebKit Commit Bot 2017-11-09 10:32:32 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 09:38:32 PST
<rdar://problem/35562135>