Bug 179391 – Make CSSOM APIs append rather than replace slots in the declaration block.

• Status: NEW
• Component: CSS

[Emilio Cobos Álvarez (:emilio)]

Otherwise logical properties work inconsistently with them.

See the URL for more background and the CSSWG resolution.

[Emilio Cobos Álvarez (:emilio)]

Created attachment 340796 [details]
Patch

[Emilio Cobos Álvarez (:emilio)]

Created attachment 340797 [details]
Patch (for CQ only)

[Emilio Cobos Álvarez (:emilio)]

Created attachment 340801 [details]
Patch

[Emilio Cobos Álvarez (:emilio)]

Updated a test to avoid depending on the number of properties the browser supports.

https://github.com/w3c/web-platform-tests/pull/11083

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 340801 [details]
Patch

Err, webkit-patch-upload got really confused. This patch should've gone in bug 185805.

[Emilio Cobos Álvarez (:emilio)]

Created attachment 340844 [details]
Patch

[Emilio Cobos Álvarez (:emilio)]

Created attachment 340852 [details]
Patch

[EWS Watchlist]

Comment on attachment 340852 [details]
Patch

Attachment 340852 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7753385

New failing tests:
fast/css/custom-properties/rule-property-set.html
fast/events/ondrop-text-html.html
editing/pasteboard/copy-paste-converts-sticky.html
editing/pasteboard/copy-paste-converts-fixed.html
fast/dom/MutationObserver/observe-attributes.html
fast/css/set-inline-style-recalc.html
fast/dom/css-set-property-exception.html

[EWS Watchlist]

Created attachment 340853 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340852 [details]
Patch

Attachment 340852 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7753392

New failing tests:
fast/css/custom-properties/rule-property-set.html
editing/pasteboard/copy-paste-converts-sticky.html
editing/pasteboard/copy-paste-converts-fixed.html
fast/dom/MutationObserver/observe-attributes.html
fast/css/set-inline-style-recalc.html
fast/dom/css-set-property-exception.html

[EWS Watchlist]

Created attachment 340854 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340852 [details]
Patch

Attachment 340852 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7753436

New failing tests:
fast/css/custom-properties/rule-property-set.html
editing/pasteboard/copy-paste-converts-sticky.html
editing/pasteboard/copy-paste-converts-fixed.html
fast/dom/MutationObserver/observe-attributes.html
fast/css/set-inline-style-recalc.html
fast/dom/css-set-property-exception.html

[EWS Watchlist]

Created attachment 340856 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 340852 [details]
Patch

Attachment 340852 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7753463

New failing tests:
fast/css/custom-properties/rule-property-set.html
fast/events/ondrop-text-html.html
editing/pasteboard/copy-paste-converts-sticky.html
editing/pasteboard/copy-paste-converts-fixed.html
fast/dom/MutationObserver/observe-attributes.html
fast/css/set-inline-style-recalc.html
fast/dom/css-set-property-exception.html

[EWS Watchlist]

Created attachment 340859 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Emilio Cobos Álvarez (:emilio)]

Created attachment 340866 [details]
Patch

[Emilio Cobos Álvarez (:emilio)]

Created attachment 340961 [details]
Patch

[Emilio Cobos Álvarez (:emilio)]

Created attachment 340965 [details]
Patch

[EWS Watchlist]

Comment on attachment 340965 [details]
Patch

Attachment 340965 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7763297

New failing tests:
fast/events/ondrop-text-html.html

[EWS Watchlist]

Created attachment 340967 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340965 [details]
Patch

Attachment 340965 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7763341

New failing tests:
fast/events/ondrop-text-html.html

[EWS Watchlist]

Created attachment 340971 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 340965 [details]
Patch

Attachment 340965 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7763564

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html

[EWS Watchlist]

Created attachment 340972 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Alex Christensen]

Comment on attachment 340965 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.