Bug 185805 - Update CSSOM WPT tests.
Summary: Update CSSOM WPT tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-20 11:17 PDT by Emilio Cobos Álvarez (:emilio)
Modified: 2018-05-20 14:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (764.92 KB, patch)
2018-05-20 11:26 PDT, Emilio Cobos Álvarez (:emilio)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.24 MB, application/zip)
2018-05-20 12:38 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.66 MB, application/zip)
2018-05-20 12:44 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-sierra (2.95 MB, application/zip)
2018-05-20 13:05 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.22 MB, application/zip)
2018-05-20 13:18 PDT, Build Bot
no flags Details
Patch for landing (764.91 KB, patch)
2018-05-20 13:19 PDT, Emilio Cobos Álvarez (:emilio)
no flags Details | Formatted Diff | Diff
Patch for landing (764.92 KB, patch)
2018-05-20 13:43 PDT, Emilio Cobos Álvarez (:emilio)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez (:emilio) 2018-05-20 11:17:49 PDT
They're quite old.
Comment 1 Emilio Cobos Álvarez (:emilio) 2018-05-20 11:26:16 PDT
Created attachment 340795 [details]
Patch
Comment 2 Emilio Cobos Álvarez (:emilio) 2018-05-20 12:12:27 PDT
Comment on attachment 340795 [details]
Patch

Thanks for the review Fred!
Comment 3 Build Bot 2018-05-20 12:38:55 PDT
Comment on attachment 340795 [details]
Patch

Attachment 340795 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7745644

New failing tests:
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
Comment 4 Build Bot 2018-05-20 12:38:56 PDT
Created attachment 340798 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 Build Bot 2018-05-20 12:44:54 PDT
Comment on attachment 340795 [details]
Patch

Attachment 340795 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7745653

New failing tests:
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
Comment 6 Build Bot 2018-05-20 12:44:56 PDT
Created attachment 340799 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 Build Bot 2018-05-20 13:05:21 PDT
Comment on attachment 340795 [details]
Patch

Attachment 340795 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7745683

New failing tests:
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
Comment 8 Build Bot 2018-05-20 13:05:23 PDT
Created attachment 340800 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 Build Bot 2018-05-20 13:18:51 PDT
Comment on attachment 340795 [details]
Patch

Attachment 340795 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7745696

New failing tests:
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
Comment 10 Build Bot 2018-05-20 13:18:52 PDT
Created attachment 340802 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 11 Emilio Cobos Álvarez (:emilio) 2018-05-20 13:19:25 PDT
Created attachment 340803 [details]
Patch for landing
Comment 12 Emilio Cobos Álvarez (:emilio) 2018-05-20 13:20:49 PDT
Submitted a test change upstream to avoid printing the number of properties in the expectation.

https://github.com/w3c/web-platform-tests/pull/11083
Comment 13 WebKit Commit Bot 2018-05-20 13:29:56 PDT
Comment on attachment 340803 [details]
Patch for landing

Rejecting attachment 340803 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 340803, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Frederic Wang found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/7746061
Comment 14 Emilio Cobos Álvarez (:emilio) 2018-05-20 13:42:29 PDT
Sigh, unicode :)
Comment 15 Emilio Cobos Álvarez (:emilio) 2018-05-20 13:43:04 PDT
Created attachment 340804 [details]
Patch for landing
Comment 16 WebKit Commit Bot 2018-05-20 14:41:15 PDT
Comment on attachment 340804 [details]
Patch for landing

Clearing flags on attachment: 340804

Committed r232005: <https://trac.webkit.org/changeset/232005>
Comment 17 WebKit Commit Bot 2018-05-20 14:41:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 18 Radar WebKit Bug Importer 2018-05-20 14:42:30 PDT
<rdar://problem/40402665>