Bug 179372 - [WPE][GTK] Building with ENABLE_VIDEO=OFF fails to find AudioTrack.idl
Summary: [WPE][GTK] Building with ENABLE_VIDEO=OFF fails to find AudioTrack.idl
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
Keywords: InRadar
: 180948 (view as bug list)
Depends on:
Blocks: 179373
  Show dependency treegraph
Reported: 2017-11-07 04:36 PST by Adrian Perez
Modified: 2017-12-19 14:05 PST (History)
13 users (show)

See Also:

Patch (3.45 KB, patch)
2017-11-07 05:42 PST, Adrian Perez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (1.00 MB, application/zip)
2017-11-07 07:05 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-11-07 04:36:56 PST
The error message from “generate-bindings-all.pl” is:

   AudioTrack.idl not found, but it is supplemented by /home/aperez/devel/WebKit/Source/WebCore/Modules/mediasource/AudioTrackMediaSource.idl
       at /home/aperez/devel/WebKit/Source/WebCore/bindings/scripts/preprocess-idls.pl line 164.
   Died at /home/aperez/devel/WebKit/Source/WebCore/bindings/scripts/generate-bindings-all.pl line 85.

I have not copied the command line that fails because it's humongous.
Looking at the build directory, there “AudioTrack.idl” file under
“DerivedSources/”, though of course it does exist under the “Source/”

   % find cmakebuild/ -name AudioTrack.idl
   % find Source/ -name AudioTrack.idl    
Comment 1 Adrian Perez 2017-11-07 04:49:38 PST
We used not to build “AudioTrackMediaSource.idl” before bug 174620
was fixed. Shuffling around things in the CMake build files to only
build this when ENABLE_MEDIA_SOURCE is enabled should work. I'll
also make sure that the other additional added for building in
r222205 don't break building with ENABLE_VIDEO=OFF.
Comment 2 Adrian Perez 2017-11-07 05:42:15 PST
Created attachment 326206 [details]
Comment 3 Adrian Perez 2017-11-07 05:46:35 PST
(In reply to Adrian Perez from comment #2)
> Created attachment 326206 [details]
> Patch

I tested building with all the possible combinations of ENABLE_VIDEO,
ENABLE_VIDEO_TRACK, and ENABLE_MEDIA_SOURCE — all worked fine with the
patch applied =)
Comment 4 Michael Catanzaro 2017-11-07 06:17:44 PST
Comment on attachment 326206 [details]

r=me. You can set cq+ yourself if EWS likes it (or if any EWS failures are unrelated).
Comment 5 Build Bot 2017-11-07 07:05:31 PST
Comment on attachment 326206 [details]

Attachment 326206 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5134142

New failing tests:
Comment 6 Build Bot 2017-11-07 07:05:33 PST
Created attachment 326209 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 7 Adrian Perez 2017-11-07 08:08:18 PST
Comment on attachment 326206 [details]

The ios-sim EWS failure seems unrelated — there has been today other
failures in Service Workers tests. I'm marking this with cq+ and I'll
keep an eye on the bots just in case.
Comment 8 WebKit Commit Bot 2017-11-07 08:28:28 PST
Comment on attachment 326206 [details]

Clearing flags on attachment: 326206

Committed r224533: <https://trac.webkit.org/changeset/224533>
Comment 9 WebKit Commit Bot 2017-11-07 08:28:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-11-15 12:09:52 PST
Comment 11 Timothy Hatcher 2017-12-19 14:05:06 PST
*** Bug 180948 has been marked as a duplicate of this bug. ***