Bug 174620 - [GTK] The binding code of Media Source Extension of AudioTrack, VideoTrack and TextTrack is not generated
Summary: [GTK] The binding code of Media Source Extension of AudioTrack, VideoTrack an...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nael Ouedraogo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-18 02:43 PDT by Nael Ouedraogo
Modified: 2017-11-07 05:48 PST (History)
5 users (show)

See Also:


Attachments
Patch (13.79 KB, patch)
2017-07-18 03:22 PDT, Nael Ouedraogo
no flags Details | Formatted Diff | Diff
Patch (13.82 KB, patch)
2017-09-18 06:18 PDT, Nael Ouedraogo
no flags Details | Formatted Diff | Diff
Patch (13.85 KB, patch)
2017-09-19 01:08 PDT, Nael Ouedraogo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nael Ouedraogo 2017-07-18 02:43:32 PDT
The binding code of Media Source Extension of AudioTrack, VideoTrack and TextTrack is not generated.
Comment 1 Nael Ouedraogo 2017-07-18 03:22:11 PDT
Created attachment 315785 [details]
Patch
Comment 2 Enrique Ocaña 2017-09-05 02:39:54 PDT
This patch looks good to me, but I can't r+ it (I'm not a reviewer).
Comment 3 Michael Catanzaro 2017-09-05 08:21:32 PDT
Comment on attachment 315785 [details]
Patch

I'll rubber-stamp this since Enrique is our MSE expert. Sorry for the delay.
Comment 4 Nael Ouedraogo 2017-09-18 06:18:12 PDT
Created attachment 321088 [details]
Patch
Comment 5 Nael Ouedraogo 2017-09-18 06:19:07 PDT
Thanks for the reviews.
Comment 6 Michael Catanzaro 2017-09-18 06:34:55 PDT
Do you want me to give cq+ on this?
Comment 7 Nael Ouedraogo 2017-09-18 06:46:33 PDT
I was waiting for EWS to finish testing gtk and wpe ports. Thanks !
Comment 8 WebKit Commit Bot 2017-09-18 07:11:21 PDT
Comment on attachment 321088 [details]
Patch

Rejecting attachment 321088 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 321088, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ab9e1cc9016cf597ac9a1ca756c9f23dc5 86a8d7212f99ef652aa59bf346f93989ecd2afbd M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.
Total errors found: 0 in 1 files

Full output: http://webkit-queues.webkit.org/results/4582961
Comment 9 Nael Ouedraogo 2017-09-19 01:08:11 PDT
Created attachment 321188 [details]
Patch
Comment 10 WebKit Commit Bot 2017-09-19 02:00:19 PDT
Comment on attachment 321188 [details]
Patch

Clearing flags on attachment: 321188

Committed r222205: <http://trac.webkit.org/changeset/222205>
Comment 11 WebKit Commit Bot 2017-09-19 02:00:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2017-09-27 12:50:25 PDT
<rdar://problem/34694118>