The C API is being inadvertently exported because it's marked as WEBKIT_EXPORT in the header files. But of course it should only be exported in DEVELOPER_MODE, where it's needed for WebKitTestRunner. Use (almost) the same linker version script as GTK to fix this. It's slightly different because WPE does not have WebKitPluginProcess. This also reduces binary size of libWPEWebKit.so in debug mode from 615 MB down to 497 MB. (Haven't checked release mode.) This will break the WIP fdo backend of dyz. We should discuss which parts of the C API are really needed there (I don't immediately see anything), and how to expose them in the GLib API if needed.
Created attachment 326181 [details] Patch
Comment on attachment 326181 [details] Patch This breaks dyz for me: lib/wpe.lua:125: /home/clopez/webkit/wpe/WebKitBuild/Release/lib/libWPEWebKit.so: undefined symbol: WKPageConfigurationSetContext
(In reply to Carlos Alberto Lopez Perez from comment #2) > Comment on attachment 326181 [details] > Patch > > This breaks dyz for me: > > lib/wpe.lua:125: > /home/clopez/webkit/wpe/WebKitBuild/Release/lib/libWPEWebKit.so: undefined > symbol: WKPageConfigurationSetContext Ok.. that is because the WPE JHBuild is still building an old version of dyz that uses the C API. Let's update it first.
(In reply to Michael Catanzaro from comment #0) > This also reduces binary size of libWPEWebKit.so in debug mode from 615 MB > down to 497 MB. (Haven't checked release mode.) > Nice. In Release it reduces it in ~74 KBs less (after stripping).. Better than nothing
Comment on attachment 326181 [details] Patch Clearing flags on attachment: 326181 Committed r224642: <https://trac.webkit.org/changeset/224642>
All reviewed patches have been landed. Closing bug.