WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
179236
[Web Animations] Schedule animations registered on the document timeline
https://bugs.webkit.org/show_bug.cgi?id=179236
Summary
[Web Animations] Schedule animations registered on the document timeline
Antoine Quint
Reported
2017-11-03 02:01:58 PDT
We need to be able to schedule animations registered on the document timeline so we can update their current time as needed to then actually perform interpolations.
Attachments
Patch
(30.53 KB, patch)
2017-11-04 05:58 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-elcapitan
(1.00 MB, application/zip)
2017-11-04 07:00 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
(1.24 MB, application/zip)
2017-11-04 07:09 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews116 for mac-elcapitan
(1.82 MB, application/zip)
2017-11-04 07:16 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-wk2
(1.03 MB, application/zip)
2017-11-04 07:26 PDT
,
Build Bot
no flags
Details
Patch
(35.84 KB, patch)
2017-11-04 12:22 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-elcapitan
(1020.72 KB, application/zip)
2017-11-04 13:24 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
(1.24 MB, application/zip)
2017-11-04 13:31 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews112 for mac-elcapitan
(1.80 MB, application/zip)
2017-11-04 13:45 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews125 for ios-simulator-wk2
(1013.18 KB, application/zip)
2017-11-04 13:49 PDT
,
Build Bot
no flags
Details
Patch
(36.75 KB, patch)
2017-11-04 14:27 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch
(37.80 KB, patch)
2017-11-05 05:06 PST
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch
(37.92 KB, patch)
2017-11-05 05:07 PST
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch
(37.99 KB, patch)
2017-11-05 05:36 PST
,
Antoine Quint
dino
: review+
Details
Formatted Diff
Diff
Show Obsolete
(13)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-11-03 02:02:42 PDT
<
rdar://problem/35332669
>
Antoine Quint
Comment 2
2017-11-04 05:58:38 PDT
Created
attachment 326027
[details]
Patch
Build Bot
Comment 3
2017-11-04 07:00:00 PDT
Comment on
attachment 326027
[details]
Patch
Attachment 326027
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/5104402
New failing tests: http/wpt/web-animations/timing-model/animations/current-time.html http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html
Build Bot
Comment 4
2017-11-04 07:00:01 PDT
Created
attachment 326028
[details]
Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 5
2017-11-04 07:09:02 PDT
Comment on
attachment 326027
[details]
Patch
Attachment 326027
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/5104422
New failing tests: http/wpt/web-animations/timing-model/animations/current-time.html http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html
Build Bot
Comment 6
2017-11-04 07:09:03 PDT
Created
attachment 326029
[details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 7
2017-11-04 07:16:31 PDT
Comment on
attachment 326027
[details]
Patch
Attachment 326027
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/5104423
New failing tests: http/wpt/web-animations/timing-model/animations/current-time.html http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html
Build Bot
Comment 8
2017-11-04 07:16:33 PDT
Created
attachment 326030
[details]
Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 9
2017-11-04 07:26:05 PDT
Comment on
attachment 326027
[details]
Patch
Attachment 326027
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/5104441
New failing tests: http/wpt/web-animations/timing-model/animations/current-time.html http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html
Build Bot
Comment 10
2017-11-04 07:26:06 PDT
Created
attachment 326031
[details]
Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Antoine Quint
Comment 11
2017-11-04 12:22:20 PDT
Created
attachment 326032
[details]
Patch
Build Bot
Comment 12
2017-11-04 13:24:36 PDT
Comment on
attachment 326032
[details]
Patch
Attachment 326032
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/5106526
New failing tests: http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html
Build Bot
Comment 13
2017-11-04 13:24:37 PDT
Created
attachment 326037
[details]
Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 14
2017-11-04 13:31:53 PDT
Comment on
attachment 326032
[details]
Patch
Attachment 326032
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/5106569
New failing tests: http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html
Build Bot
Comment 15
2017-11-04 13:31:54 PDT
Created
attachment 326039
[details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 16
2017-11-04 13:45:19 PDT
Comment on
attachment 326032
[details]
Patch
Attachment 326032
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/5106663
New failing tests: http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html
Build Bot
Comment 17
2017-11-04 13:45:20 PDT
Created
attachment 326040
[details]
Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 18
2017-11-04 13:49:31 PDT
Comment on
attachment 326032
[details]
Patch
Attachment 326032
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/5106644
New failing tests: http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html
Build Bot
Comment 19
2017-11-04 13:49:32 PDT
Created
attachment 326041
[details]
Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Antoine Quint
Comment 20
2017-11-04 14:27:59 PDT
Created
attachment 326044
[details]
Patch
Antoine Quint
Comment 21
2017-11-05 05:06:02 PST
Created
attachment 326065
[details]
Patch
Antoine Quint
Comment 22
2017-11-05 05:07:20 PST
Created
attachment 326066
[details]
Patch
Antoine Quint
Comment 23
2017-11-05 05:36:10 PST
Created
attachment 326067
[details]
Patch
Dean Jackson
Comment 24
2017-11-05 14:01:29 PST
Comment on
attachment 326067
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=326067&action=review
> Source/WebCore/animation/DocumentTimeline.cpp:141 > + // whihc will be addressed by the refactor tracked by
webkit.org/b/179293
.
typo which
> Source/WebCore/animation/DocumentTimeline.cpp:163 > +void DocumentTimeline::windowScreenDidChange(PlatformDisplayID displayID) > +{ > +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
You could leave out this function completely if !USE(RAF_D_M)
> Source/WebCore/animation/DocumentTimeline.h:65 > + Document* m_document;
Why does this need to be a pointer? You get a Document& in the constructor. Maybe have this as a Ref<Document> in both places.
Antoine Quint
Comment 25
2017-11-05 14:34:19 PST
Committed
r224472
: <
https://trac.webkit.org/changeset/224472
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug