Include 'video/*' in image request Accept header if browser supports video media in image contexts.
Created attachment 325717 [details] Patch
<rdar://problem/35315768>
Comment on attachment 325717 [details] Patch Attachment 325717 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5077139 Number of test failures exceeded the failure limit.
Created attachment 325730 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325717 [details] Patch Attachment 325717 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5077157 New failing tests: media/video-controls-in-media-document.html webarchive/loading/video-in-webarchive.html media/modern-media-controls/media-documents/media-document-invalid.html fast/replaced/table-percent-height.html security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html fast/events/media-focus-in-standalone-media-document.html media/media-document-audio-size.html media/media-document-audio-controls-visible.html http/tests/misc/mask-image-accept.html http/tests/media/media-document-referer.html media/video-document-types.html http/tests/misc/image-checks-for-accept.html media/media-document-audio-repaint.html media/modern-media-controls/media-documents/click-on-video-should-not-pause.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-without-mime-type.html http/tests/media/media-document.html security/contentSecurityPolicy/object-src-none-blocks-quicktime-plugin-replacement.html media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html media/modern-media-controls/media-documents/media-document-video-mac-sizing.html media/audio-controls-timeline-in-media-document.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html media/video-click-dblckick-standalone.html
Created attachment 325731 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325717 [details] Patch Attachment 325717 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5077149 New failing tests: http/tests/images/image-supports-video.html
Created attachment 325732 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 325735 [details] Patch
Created attachment 325737 [details] Patch
Comment on attachment 325737 [details] Patch Attachment 325737 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5078726 New failing tests: security/contentSecurityPolicy/object-src-none-blocks-quicktime-plugin-replacement.html http/tests/misc/mask-image-accept.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html fast/replaced/table-percent-height.html security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html http/tests/misc/image-checks-for-accept.html
Created attachment 325748 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325737 [details] Patch Attachment 325737 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5078829 New failing tests: fast/replaced/replaced-breaking.html security/contentSecurityPolicy/object-src-none-blocks-quicktime-plugin-replacement.html http/tests/misc/mask-image-accept.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html fast/replaced/table-percent-height.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html http/tests/misc/image-checks-for-accept.html
Created attachment 325752 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325737 [details] Patch Attachment 325737 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5078811 New failing tests: http/tests/images/image-supports-video.html
Created attachment 325754 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 325737 [details] Patch Attachment 325737 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5078799 New failing tests: security/contentSecurityPolicy/object-src-none-blocks-quicktime-plugin-replacement.html http/tests/misc/mask-image-accept.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html fast/replaced/table-percent-height.html security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html http/tests/misc/image-checks-for-accept.html
Created attachment 325756 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325737 [details] Patch I'm ok with the accept header, but it looks like your "drive-by fix" caused some issues. Please fix before landing.
Created attachment 325867 [details] Patch for landing
Created attachment 325898 [details] Patch for landing
Comment on attachment 325898 [details] Patch for landing Attachment 325898 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5091037 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 325903 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325898 [details] Patch for landing Attachment 325898 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5091051 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 325904 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325898 [details] Patch for landing Attachment 325898 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5091163 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 325909 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 325910 [details] Patch for landing
Comment on attachment 325910 [details] Patch for landing Attachment 325910 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5092205 New failing tests: http/tests/images/image-supports-video.html
Created attachment 325917 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325910 [details] Patch for landing Attachment 325910 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5092368 New failing tests: http/tests/images/image-supports-video.html
Created attachment 325919 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325910 [details] Patch for landing Attachment 325910 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5092418 New failing tests: http/tests/images/image-supports-video.html
Created attachment 325926 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 325963 [details] Patch for landing
Created attachment 325973 [details] Patch for landing
Comment on attachment 325973 [details] Patch for landing Attachment 325973 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5096757 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 325983 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325973 [details] Patch for landing Attachment 325973 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5096888 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 325985 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325973 [details] Patch for landing Attachment 325973 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5097590 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 325990 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 326464 [details] Patch for landing
Created attachment 328234 [details] Patch for landing
Comment on attachment 328234 [details] Patch for landing Attachment 328234 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5467768 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 328237 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 328234 [details] Patch for landing Attachment 328234 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5467867 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 328238 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 328240 [details] Patch for landing
Comment on attachment 328240 [details] Patch for landing Attachment 328240 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5468376 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 328244 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 328240 [details] Patch for landing Attachment 328240 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5468418 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 328246 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 328240 [details] Patch for landing Attachment 328240 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5468828 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html
Created attachment 328249 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 328326 [details] Patch for landing
Comment on attachment 328326 [details] Patch for landing Clearing flags on attachment: 328326 Committed r225472: <https://trac.webkit.org/changeset/225472>
All reviewed patches have been landed. Closing bug.
The test added in this patch is extremely flaky on macOS Sierra and High Sierra WK1: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fimages%2Fimage-supports-video.html https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r226129%20(5383)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/5383 diff: --- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/http/tests/images/image-supports-video-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/http/tests/images/image-supports-video-actual.txt @@ -1,2 +1,2 @@ -PASS: video source selected. +FAIL: <img> threw error.