Bug 179173 - [GTK] http/tests/inspector/network/har/har-page.html is failing
Summary: [GTK] http/tests/inspector/network/har/har-page.html is failing
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-02 08:56 PDT by Miguel Gomez
Modified: 2019-11-27 04:30 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2017-11-02 08:56:05 PDT
http/tests/inspector/network/har/har-page.html [ Failure ]

since it was added in r223856
Comment 1 Joseph Pecoraro 2017-11-02 11:13:57 PDT
What was the expectation diff?
Comment 2 Michael Catanzaro 2017-11-02 12:43:18 PDT
httpVersion is missing:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt
@@ -29,7 +29,7 @@
         "request": {
           "method": "GET",
           "url": "http://127.0.0.1:8000/inspector/network/har/har-page.html",
-          "httpVersion": "HTTP/1.1",
+          "httpVersion": "",
           "cookies": [],
           "headers": "<filtered>",
           "queryString": [],
@@ -39,7 +39,7 @@
         "response": {
           "status": 200,
           "statusText": "OK",
-          "httpVersion": "HTTP/1.1",
+          "httpVersion": "",
           "cookies": [],
           "headers": "<filtered>",
           "content": {
Comment 3 Joseph Pecoraro 2017-11-02 13:12:47 PDT
Ahh interesting, thanks!

So the `protocol` comes from WebCore::NetworkLoadMetrics, typically populated in the NetworkProcess where NetworkLoadMetrics is constructed. I guess the protocol isn't populated yet by linux, or if it is it has an unexpected value.

For now you could check in a GTK expectation. I don't think this will be flakey.
Comment 4 Michael Catanzaro 2017-11-20 16:13:18 PST

*** This bug has been marked as a duplicate of bug 179781 ***
Comment 5 Nikolas Zimmermann 2019-11-27 04:30:50 PST
According to https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/11947/steps/layout-test/logs/stdio the test is actually flakey on Gtk.

Changing test expectations.