Avoid duplicating code for dist and distcheck targets between GTK and WPE
Created attachment 325682 [details] Patch
Created attachment 325683 [details] Patch
Comment on attachment 325683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325683&action=review > Tools/Scripts/make-dist:1 > +#!/usr/bin/env python2 Why did you change this? Does this fail to run with python3?
(In reply to Carlos Garcia Campos from comment #3) > Comment on attachment 325683 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=325683&action=review > > > Tools/Scripts/make-dist:1 > > +#!/usr/bin/env python2 > > Why did you change this? Does this fail to run with python3? I didn't try, but I assume all our scripts will fail to run with python3 unless tested otherwise. I can leave it as-is.
Comment on attachment 325683 [details] Patch Both EWS are broken
Created attachment 325710 [details] Patch
Created attachment 325711 [details] Patch
(In reply to Michael Catanzaro from comment #4) > I didn't try, but I assume all our scripts will fail to run with python3 > unless tested otherwise. I can leave it as-is. This is a change that can be done in another bug. You can for example seize and globally replace "python" with "python-2.7" in all python shebang (as we discussed a while ago on the webkit-dev mailing lists). On Debian, the python namespace still defaults to 2.7
Comment on attachment 325711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325711&action=review > Tools/Scripts/make-dist:1 > +#!/usr/bin/env python I switched it back, since I agree it's a problem for another bug.
Comment on attachment 325711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325711&action=review Informally reviewing: Looks good to me / r+. > Source/cmake/WebKitDist.cmake:24 > + VERBATIM #TIL about “VERBATIM” — certainly nicer that interspersing double-quote characters all around :-)
(In reply to Adrian Perez from comment #10) > #TIL about “VERBATIM” — certainly nicer that interspersing double-quote > characters all around :-) Yeah, Konstantin wants us to always use it for all custom targets and commands.
Comment on attachment 325711 [details] Patch Clearing flags on attachment: 325711 Committed r224410: <https://trac.webkit.org/changeset/224410>
All reviewed patches have been landed. Closing bug.