Bug 179124 - TestController platformAdjustContext should use provided WKContext for Mac
Summary: TestController platformAdjustContext should use provided WKContext for Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-01 10:11 PDT by Jonathan Bedard
Modified: 2017-11-03 09:34 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2017-11-01 10:15 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1023.61 KB, application/zip)
2017-11-01 11:36 PDT, Build Bot 		no flags Details
Patch (1.60 KB, patch)
2017-11-02 12:56 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-11-01 10:11:01 PDT 
In the Cocoa test controller, we re-create a ProcessPool instead of using the provided WKContext.  initializeWebViewConfiguration is called by platformAdjustContext, the name of this function implies that the context is used and modified, not replaced.
Comment 1 Radar WebKit Bug Importer 2017-11-01 10:11:43 PDT 
<rdar://problem/35295176>
Comment 2 Jonathan Bedard 2017-11-01 10:15:13 PDT 
Created attachment 325583 [details]
Patch
Comment 3 Build Bot 2017-11-01 11:36:37 PDT 
Comment on attachment 325583 [details]
Patch

Attachment 325583 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5063914

New failing tests:
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html
Comment 4 Build Bot 2017-11-01 11:36:38 PDT 
Created attachment 325601 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 5 Jonathan Bedard 2017-11-02 12:56:07 PDT 
Created attachment 325753 [details]
Patch
Comment 6 Jonathan Bedard 2017-11-02 12:59:21 PDT 
Re-uploading patch....looks like that failure was caused by <https://bugs.webkit.org/show_bug.cgi?id=179137>.
Comment 7 WebKit Commit Bot 2017-11-03 09:34:02 PDT 
Comment on attachment 325753 [details]
Patch

Clearing flags on attachment: 325753

Committed r224401: <https://trac.webkit.org/changeset/224401>
Comment 8 WebKit Commit Bot 2017-11-03 09:34:04 PDT 
All reviewed patches have been landed.  Closing bug.