Bug 179137 - LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html is a flaky failure
Summary: LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serv...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-01 13:50 PDT by Ryan Haddad
Modified: 2017-12-20 11:29 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.92 KB, patch)
2017-12-19 18:25 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-11-01 13:50:53 PDT
LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html is a flaky failure

https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r224281%20(982)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fcache-storage%2Fserviceworker%2Fcache-match.https.html

--- /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt
+++ /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-actual.txt
@@ -15,7 +15,7 @@
 PASS Cache.match with responses containing "Vary" header 
 PASS Cache.match with Request and Response objects with different URLs 
 PASS Cache.match invoked multiple times for the same Request/Response 
-PASS Cache.match blob should be sliceable 
+FAIL Cache.match blob should be sliceable assert_equals: A Response blob returned by Cache.match should be sliceable. expected (string) "simple" but got (object) null
 PASS Cache.match with POST Request 
 PASS Cache.match with a non-2xx Response 
 PASS Cache.match with a network error Response
Comment 1 Ryan Haddad 2017-11-01 13:53:11 PDT
This test has been flaky since it was re-enabled in https://trac.webkit.org/r224250
Comment 2 Chris Dumez 2017-11-01 14:07:33 PDT
Temporarily marked as flaky in <https://trac.webkit.org/changeset/224294>.
Comment 3 Radar WebKit Bug Importer 2017-11-03 09:51:35 PDT
<rdar://problem/35337335>
Comment 4 Chris Dumez 2017-11-27 10:25:11 PST
Does not seem to be flaky anymore. Will unskip shortly.
Comment 5 Ryan Haddad 2017-11-27 15:00:16 PST
This test is still very flaky and should not have been re-enabled.
Comment 6 Chris Dumez 2017-11-27 15:01:14 PST
(In reply to Ryan Haddad from comment #5)
> This test is still very flaky and should not have been re-enabled.

Flakiness dashboard was all green when I checked, or so I thought?
Comment 7 Ryan Haddad 2017-11-27 15:06:15 PST
(In reply to Chris Dumez from comment #6)
> (In reply to Ryan Haddad from comment #5)
> > This test is still very flaky and should not have been re-enabled.
> 
> Flakiness dashboard was all green when I checked, or so I thought?
It was for the other tests that were re-enabled, but not this one. 

I marked it as flaky again in https://trac.webkit.org/changeset/225197/webkit
Comment 8 youenn fablet 2017-12-19 18:25:04 PST
Created attachment 329866 [details]
Patch
Comment 9 WebKit Commit Bot 2017-12-20 11:29:12 PST
Comment on attachment 329866 [details]
Patch

Clearing flags on attachment: 329866

Committed r226193: <https://trac.webkit.org/changeset/226193>
Comment 10 WebKit Commit Bot 2017-12-20 11:29:14 PST
All reviewed patches have been landed.  Closing bug.