Bug 179098 - REGRESSION(r224192): [WPE] Fix WebEventFactory::createWebWheelEvent
Summary: REGRESSION(r224192): [WPE] Fix WebEventFactory::createWebWheelEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 178894
  Show dependency tree / graph
 
Reported: 2017-10-31 18:09 PDT by Michael Catanzaro
Modified: 2017-11-15 12:08 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2017-10-31 18:26 PDT, Michael Catanzaro 		sam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1007.67 KB, application/zip)
2017-10-31 19:38 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-10-31 18:09:20 PDT 
../../Source/WebKit/Shared/wpe/WebEventFactory.cpp:159:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
         delta = wheelTicks;
         ~~~~~~^~~~~~~~~~~~
../../Source/WebKit/Shared/wpe/WebEventFactory.cpp:160:5: note: here
     default:
     ^~~~~~~
Comment 1 Michael Catanzaro 2017-10-31 18:25:46 PDT 
Ooops, this is my fault.
Comment 2 Michael Catanzaro 2017-10-31 18:26:18 PDT 
Created attachment 325535 [details]
Patch
Comment 3 Build Bot 2017-10-31 19:38:06 PDT 
Comment on attachment 325535 [details]
Patch

Attachment 325535 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5058141

New failing tests:
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html
Comment 4 Build Bot 2017-10-31 19:38:07 PDT 
Created attachment 325539 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 5 Michael Catanzaro 2017-11-01 05:21:11 PDT 
Committed r224274: <https://trac.webkit.org/changeset/224274>