Bug 179039 – [WPE] -Wsign-compare warning in EventSenderProxyWPE.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Michael Catanzaro]

In bug #178899 I was accidentally using a release build, so I missed a spot:

[1342/1390] Building CXX object Tools/...nner.dir/wpe/EventSenderProxyWPE.cpp.o
In file included from ../../Source/WTF/wtf/CheckedArithmetic.h:29:0,
                 from ../../Source/WTF/wtf/Vector.h:29,
                 from ../../Source/WTF/wtf/Deque.h:37,
                 from ../../Tools/WebKitTestRunner/EventSenderProxy.h:30,
                 from ../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:27:
../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: In member function ‘void WTR::EventSenderProxy::updateTouchPoint(int, int, int)’:
../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:292:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     ASSERT(index >= 0 && index <= m_touchEvents.size());
                          ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
../../Source/WTF/wtf/Assertions.h:301:11: note: in definition of macro ‘ASSERT’
     if (!(assertion)) { \
           ^~~~~~~~~
../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: In member function ‘void WTR::EventSenderProxy::releaseTouchPoint(int)’:
../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:367:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     ASSERT(index >= 0 && index <= m_touchEvents.size());
                          ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
../../Source/WTF/wtf/Assertions.h:301:11: note: in definition of macro ‘ASSERT’
     if (!(assertion)) { \
           ^~~~~~~~~

[Michael Catanzaro]

Created attachment 325412 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 325412 [details]
Patch

Clearing flags on attachment: 325412

Committed r224488: <https://trac.webkit.org/changeset/224488>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.