Bug 179039 - [WPE] -Wsign-compare warning in EventSenderProxyWPE.cpp
Summary: [WPE] -Wsign-compare warning in EventSenderProxyWPE.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 178894
  Show dependency tree / graph
 
Reported: 2017-10-30 17:29 PDT by Michael Catanzaro
Modified: 2017-11-15 12:08 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2017-10-30 19:36 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-10-30 17:29:42 PDT 
In bug #178899 I was accidentally using a release build, so I missed a spot:

[1342/1390] Building CXX object Tools/...nner.dir/wpe/EventSenderProxyWPE.cpp.o
In file included from ../../Source/WTF/wtf/CheckedArithmetic.h:29:0,
                 from ../../Source/WTF/wtf/Vector.h:29,
                 from ../../Source/WTF/wtf/Deque.h:37,
                 from ../../Tools/WebKitTestRunner/EventSenderProxy.h:30,
                 from ../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:27:
../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: In member function ‘void WTR::EventSenderProxy::updateTouchPoint(int, int, int)’:
../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:292:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     ASSERT(index >= 0 && index <= m_touchEvents.size());
                          ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
../../Source/WTF/wtf/Assertions.h:301:11: note: in definition of macro ‘ASSERT’
     if (!(assertion)) { \
           ^~~~~~~~~
../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: In member function ‘void WTR::EventSenderProxy::releaseTouchPoint(int)’:
../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:367:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     ASSERT(index >= 0 && index <= m_touchEvents.size());
                          ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
../../Source/WTF/wtf/Assertions.h:301:11: note: in definition of macro ‘ASSERT’
     if (!(assertion)) { \
           ^~~~~~~~~
Comment 1 Michael Catanzaro 2017-10-30 19:36:42 PDT 
Created attachment 325412 [details]
Patch
Comment 2 WebKit Commit Bot 2017-11-06 06:42:58 PST 
Comment on attachment 325412 [details]
Patch

Clearing flags on attachment: 325412

Committed r224488: <https://trac.webkit.org/changeset/224488>
Comment 3 WebKit Commit Bot 2017-11-06 06:43:00 PST 
All reviewed patches have been landed.  Closing bug.