Bug 178898 - [WPE] Upstream or stop using cairo-egl-device-create-for-egl-surface.patch
Summary: [WPE] Upstream or stop using cairo-egl-device-create-for-egl-surface.patch
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Depends on:
Blocks: 178894
  Show dependency treegraph
Reported: 2017-10-26 16:55 PDT by Michael Catanzaro
Modified: 2017-11-15 12:09 PST (History)
7 users (show)

See Also:

Patch (6.39 KB, patch)
2017-10-26 17:44 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-10-26 16:55:21 PDT
We currently have Tools/wpe/patches/cairo-egl-device-create-for-egl-surface.patch. We need to either upstream that patch and wait patiently for the next cairo release, or else find a way to not require it, since we surely don't want to create a release that won't actually build on any platforms.

I've done a bit of grepping and I think it may be completely unused, so this might be an easy problem to resolve.
Comment 1 Michael Catanzaro 2017-10-26 17:40:34 PDT
I didn't do a clean build, but reran update-webkitwpe-libs and rebuilt WPE, and it builds just fine without the patch. Let's get rid of it and see if anything breaks. But I guess it's only needed downstream or something.
Comment 2 Michael Catanzaro 2017-10-26 17:44:50 PDT
Created attachment 325088 [details]
Comment 3 Adrian Perez 2017-10-27 01:35:37 PDT
Comment on attachment 325088 [details]

r+ (informal)

Same opinion here, and I also checked that building without
the patch seems to work fine.
Comment 4 WebKit Commit Bot 2017-10-30 11:14:03 PDT
Comment on attachment 325088 [details]

Clearing flags on attachment: 325088

Committed r224190: <https://trac.webkit.org/changeset/224190>
Comment 5 WebKit Commit Bot 2017-10-30 11:14:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Olivier Blin 2017-11-07 07:38:49 PST
For reference, usage of cairo_egl_device_create_for_egl_surface() has been removed in this commit (March 2017) downstream: