WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
178816
Make toJS() do the right thing for ServiceWorkerClient
https://bugs.webkit.org/show_bug.cgi?id=178816
Summary
Make toJS() do the right thing for ServiceWorkerClient
Chris Dumez
Reported
2017-10-25 11:03:24 PDT
Make toJS() to the right thing for ServiceWorkerClient.
Attachments
Patch
(11.19 KB, patch)
2017-10-25 11:12 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(11.33 KB, patch)
2017-10-25 12:39 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(11.19 KB, patch)
2017-10-25 14:11 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2017-10-25 11:12:42 PDT
Created
attachment 324853
[details]
Patch
Chris Dumez
Comment 2
2017-10-25 12:39:34 PDT
Created
attachment 324867
[details]
Patch
youenn fablet
Comment 3
2017-10-25 14:02:19 PDT
Comment on
attachment 324867
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=324867&action=review
> Source/WebCore/ChangeLog:8 > + Make toJS() to the right thing for ServiceWorkerClient. In particular,
s/to/do/
> Source/WebCore/bindings/js/JSServiceWorkerClientCustom.cpp:33 > +#include "ServiceWorkerWindowClient.h"
These two "Service.." are probably not needed. JSServiceWorkerWindowClient.h is also probably including JSServiceWorkerClient.h.
Chris Dumez
Comment 4
2017-10-25 14:11:17 PDT
Created
attachment 324893
[details]
Patch
Chris Dumez
Comment 5
2017-10-25 14:36:44 PDT
Comment on
attachment 324893
[details]
Patch Clearing flags on attachment: 324893 Committed
r223985
: <
https://trac.webkit.org/changeset/223985
>
Chris Dumez
Comment 6
2017-10-25 14:36:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2017-11-15 12:48:10 PST
<
rdar://problem/35568174
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug