Bug 178816 - Make toJS() do the right thing for ServiceWorkerClient
Summary: Make toJS() do the right thing for ServiceWorkerClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 178812
Blocks: 178794
  Show dependency tree / graph
 
Reported: 2017-10-25 11:03 PDT by Chris Dumez
Modified: 2017-11-15 12:48 PST (History)
7 users (show)

See Also:

Attachments
Patch (11.19 KB, patch)
2017-10-25 11:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.33 KB, patch)
2017-10-25 12:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.19 KB, patch)
2017-10-25 14:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-25 11:03:24 PDT 
Make toJS() to the right thing for ServiceWorkerClient.
Comment 1 Chris Dumez 2017-10-25 11:12:42 PDT 
Created attachment 324853 [details]
Patch
Comment 2 Chris Dumez 2017-10-25 12:39:34 PDT 
Created attachment 324867 [details]
Patch
Comment 3 youenn fablet 2017-10-25 14:02:19 PDT 
Comment on attachment 324867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324867&action=review

> Source/WebCore/ChangeLog:8
> +        Make toJS() to the right thing for ServiceWorkerClient. In particular,

s/to/do/

> Source/WebCore/bindings/js/JSServiceWorkerClientCustom.cpp:33
> +#include "ServiceWorkerWindowClient.h"

These two "Service.." are probably not needed.
JSServiceWorkerWindowClient.h is also probably including JSServiceWorkerClient.h.
Comment 4 Chris Dumez 2017-10-25 14:11:17 PDT 
Created attachment 324893 [details]
Patch
Comment 5 Chris Dumez 2017-10-25 14:36:44 PDT 
Comment on attachment 324893 [details]
Patch

Clearing flags on attachment: 324893

Committed r223985: <https://trac.webkit.org/changeset/223985>
Comment 6 Chris Dumez 2017-10-25 14:36:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 12:48:10 PST 
<rdar://problem/35568174>