Bug 178812 – [Service Worker] Add stubs for serviceWorkerClient.type

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Replace FrameType with ClientType to match the latest specification:
- https://w3c.github.io/ServiceWorker/#enumdef-clienttype

[Chris Dumez]

Created attachment 324846 [details]
Patch

[Chris Dumez]

Created attachment 324851 [details]
Patch

[Ben Kelly]

Please note, neither chrome or firefox has removed FrameType.  It might get added back.  See:

https://github.com/w3c/ServiceWorker/issues/732#issuecomment-291056364

[Chris Dumez]

Comment on attachment 324846 [details]
Patch

Ok, will keep frameType for now. Just add type.

[Chris Dumez]

Created attachment 324855 [details]
Patch

[youenn fablet]

Comment on attachment 324855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324855&action=review

> Source/WebCore/ChangeLog:9
> +        - ttps://w3c.github.io/ServiceWorker/#enumdef-clienttype

s//ttps/https

> Source/WebCore/ChangeLog:19
> +        * workers/service/ServiceWorkerClientType.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.idl.

Added

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:2924
> +		8369FDFC1FA102E300C1FF1F /* ServiceWorkerClientType.h in Headers */ = {isa = PBXBuildFile; fileRef = 8369FDFB1FA102CB00C1FF1F /* ServiceWorkerClientType.h */; };

Shouldn't there also be some JSServiceWorkerClientType. files added?

[Chris Dumez]

Created attachment 324862 [details]
Patch

[Chris Dumez]

Comment on attachment 324862 [details]
Patch

Clearing flags on attachment: 324862

Committed r223973: <https://trac.webkit.org/changeset/223973>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35568284>