Bug 178759 – Test fast/writing-mode/english-bt-text-with-spelling-marker.html should wait for editing commands to complete

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

The test fast/writing-mode/english-bt-text-with-spelling-marker.html (added in bug #223845) should wait for editing commands to complete to ensure the spellcheck is triggered.

[Daniel Bates]

Created attachment 324747 [details]
Layout test

[Daniel Bates]

(In reply to Daniel Bates from comment #0)
> The test fast/writing-mode/english-bt-text-with-spelling-marker.html (added
> in bug #223845) should wait for editing commands to complete to ensure the
> spellcheck is triggered.

*bug #178671

[Ryosuke Niwa]

Comment on attachment 324747 [details]
Layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=324747&action=review

> LayoutTests/ChangeLog:9
> +        character is typed before proceeding to type the next character.

Should mention that we're inserting a delay instead of saying they're typed.

> LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:32
> +    for (var c of text)

Use const?

> LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html:36
> +    for (var c of text)

Ditto.

[Daniel Bates]

(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 324747 [details]
> Layout test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=324747&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        character is typed before proceeding to type the next character.
> 
> Should mention that we're inserting a delay instead of saying they're typed.
> 

Will change the text in the ChangeLog to read:

Make use of typeCharacterCommand() from (LayoutTests/editing/editing.js) to type each character with a delay and delay test completion until all characters have been typed.

> > LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:32
> > +    for (var c of text)
> 
> Use const?
> 

Will fix before landing.

> > LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html:36
> > +    for (var c of text)
> 
> Ditto.

Will fix before landing.

[Daniel Bates]

Committed r223938: <https://trac.webkit.org/changeset/223938>

[Daniel Bates]

For completeness, the test fast/writing-mode/english-bt-text-with-spelling-marker.html was seen as flaky on the Apple Sierra Release WK1 (Tests) bot:
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r223917%20(5549)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/5549

[Daniel Bates]

The test is still flaky :(

Apple El Capitan Release WK1 (Tests):
https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r223952%20(5724)/results.html

[Daniel Bates]

(In reply to Daniel Bates from comment #7)
> The test is still flaky :(
> 
> Apple El Capitan Release WK1 (Tests):
> https://build.webkit.org/results/
> Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r223952%20(5724)/results.html

Committed attempt to fix the flakiness in <https://trac.webkit.org/changeset/223959>.

[Radar WebKit Bug Importer]

<rdar://problem/35568189>