178671 – Add tests to ensure spelling error dots are drawn in the correct place in bottom-to-top and right-to-left writing modes

Bug 178671 - Add tests to ensure spelling error dots are drawn in the correct place in bottom-to-top and right-to-left writing modes

Summary: Add tests to ensure spelling error dots are drawn in the correct place in bot...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	WebKit Local Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Daniel Bates

URL:
Keywords:	InRadar

Depends on:
Blocks:	178232 178759
	Show dependency tree / graph

Reported:	2017-10-23 10:47 PDT by Daniel Bates
Modified:	2017-11-15 12:52 PST (History)
CC List:	5 users (show)

See Also:

Attachments
Layout tests (7.47 KB, patch) 2017-10-23 10:52 PDT, Daniel Bates	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Bates 2017-10-23 10:47:30 PDT

Add tests to ensure spelling error dots are drawn in the correct place in bottom-to-top and right-to-left writing modes.

Comment 1 Daniel Bates 2017-10-23 10:52:29 PDT

Created attachment 324565 [details]
Layout tests

Comment 2 Daniel Bates 2017-10-23 11:10:20 PDT

Comment on attachment 324565 [details]
Layout tests

Clearing flags on attachment: 324565

Committed r223845: <https://trac.webkit.org/changeset/223845>

Comment 3 Daniel Bates 2017-10-23 11:10:21 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Matt Lewis 2017-10-24 13:34:48 PDT

These test are also flaky image only failures on WK1 as well. Should these be marked like the mac-wk2 tests?

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fwriting-mode%2Fenglish-bt-text-with-spelling-marker.html

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r223908%20(5545)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/5545

Comment 5 Radar WebKit Bug Importer 2017-11-15 12:52:13 PST

<rdar://problem/35568313>