Bug 178642 - stress/check-string-ident.js is improperly skipped
Summary: stress/check-string-ident.js is improperly skipped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 108645
  Show dependency tree / graph
 
Reported: 2017-10-22 02:12 PDT by Zan Dobersek
Modified: 2017-11-15 13:11 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.16 KB, patch)
2017-10-22 02:15 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-10-22 02:12:25 PDT 
The stress/check-string-ident.js was added in r207017:
https://trac.webkit.org/changeset/207017/webkit

It was later skipped in r208205:
https://trac.webkit.org/changeset/208205/webkit

It's still flaky, with the number of DFG compiles varying across different runs.

It's not properly skipped though -- while the skip directive is used in the JS file, the following defaultNoEagerRun directive still sets up the test to run as if the skipping wasn't done.
Comment 1 Zan Dobersek 2017-10-22 02:15:56 PDT 
Created attachment 324523 [details]
Patch
Comment 2 Zan Dobersek 2017-10-22 02:19:57 PDT 
Comment on attachment 324523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324523&action=review

> JSTests/stress/check-string-ident.js:-2
> +// Skipped due to flakiness, used defaultNoEagerRun before.
>  //@ skip
> -//@ defaultNoEagerRun

This enforces skipping on all platforms (as it was probably intended), but I've only seen the test fail on ARM platforms.
Comment 3 Zan Dobersek 2017-10-22 22:27:31 PDT 
Comment on attachment 324523 [details]
Patch

Clearing flags on attachment: 324523

Committed r223832: <https://trac.webkit.org/changeset/223832>
Comment 4 Zan Dobersek 2017-10-22 22:27:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-15 13:11:23 PST 
<rdar://problem/35568948>