Bug 178611 - Add tests to ensure spelling error dots are drawn in the correct place for overlapping lines
Summary: Add tests to ensure spelling error dots are drawn in the correct place for ov...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 178232
  Show dependency tree / graph
 
Reported: 2017-10-20 17:03 PDT by Daniel Bates
Modified: 2017-10-23 10:52 PDT (History)
6 users (show)

See Also:

Attachments
[Screenshot] Expected (shipping Safari on macOS Sierra) (7.52 KB, image/png)
2017-10-20 17:05 PDT, Daniel Bates 		no flags Details
[Screenshot] Bug (8.39 KB, image/png)
2017-10-20 17:06 PDT, Daniel Bates 		no flags Details
Example (580 bytes, text/html)
2017-10-20 17:07 PDT, Daniel Bates 		no flags Details
Patch and layout tests (10.36 KB, patch)
2017-10-20 17:33 PDT, Daniel Bates 		zalan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-10-20 17:03:30 PDT 
Spelling error dots drawn in wrong place for overlapping lines.
Comment 1 Daniel Bates 2017-10-20 17:05:29 PDT 
Created attachment 324471 [details]
[Screenshot] Expected (shipping Safari on macOS Sierra)

Disregarding the orientation of the dots (this was fixed in bug #176949), this screenshot represents the expected position for the dots.
Comment 2 Daniel Bates 2017-10-20 17:06:09 PDT 
Created attachment 324472 [details]
[Screenshot] Bug

Screenshot following r223699.
Comment 3 Daniel Bates 2017-10-20 17:07:21 PDT 
Created attachment 324473 [details]
Example
Comment 4 Radar WebKit Bug Importer 2017-10-20 17:08:37 PDT 
<rdar://problem/35105805>
Comment 5 Daniel Bates 2017-10-20 17:33:03 PDT 
Created attachment 324477 [details]
Patch and layout tests
Comment 6 Daniel Bates 2017-10-23 10:41:48 PDT 
As it turns outs I decided to revert r223699 in <https://trac.webkit.org/changeset/223840> because it causes regressions in addition to the one reported in this bug. I will incorporate the source code changes from the patch on this bug (attachment #324477 [details]) into an updated patch for bug #178232. I am re-purposing this bug to land the layout tests included in attachment #324477 [details]. This will ensure that we do not regress painting of spelling dots in overlapping lines.
Comment 7 Daniel Bates 2017-10-23 10:49:30 PDT 
Committed r223842: <https://trac.webkit.org/changeset/223842>