Bug 176949 – [Mac] Spelling, grammar and correction dots are painted upside down

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Daniel Bates]

Sunlight falls from the sky. It does not rise from the earth. The dots are upside down.

[Radar WebKit Bug Importer]

<rdar://problem/34441098>

[Daniel Bates]

Created attachment 320805 [details]
Patch

[Daniel Bates]

Created attachment 320806 [details]
[Screenshot] Before patch

[Daniel Bates]

Created attachment 320807 [details]
[Screenshot] After patch

[Daniel Bates]

Created attachment 320808 [details]
[Screenshot] TextEdit

For comparison, attached screenshot of the same text seen in the Before patch and After patch screenshots rendered in TextEdit with spelling and grammar checking enabled.

[Daniel Bates]

If you look closely at screenshots "After patch" (attachment #320807 [details]) and "TextEdit" (attachment #320808 [details]) you will notice that the dots are shifted to the right in the latter. Filed bug #176951 to address this issue.

[Simon Fraser (smfr)]

Comment on attachment 320805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320805&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:322
> +        CGContextClipToRect(context, destinationRect);

Might as well convert this function (replace the CGContextSaveGState above this diff) to use CGContextStateSaver.

> Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:333
>          // FIXME: Rather than getting the NSImage and then picking the CGImage from it, we should do what iOS does and
>          // just load the CGImage in the first place.

Should we actually do this bit now?

[Daniel Bates]

(In reply to Simon Fraser (smfr) from comment #7)
> Comment on attachment 320805 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320805&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:322
> > +        CGContextClipToRect(context, destinationRect);
> 
> Might as well convert this function (replace the CGContextSaveGState above
> this diff) to use CGContextStateSaver.
> 

OK.

> > Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:333
> >          // FIXME: Rather than getting the NSImage and then picking the CGImage from it, we should do what iOS does and
> >          // just load the CGImage in the first place.
> 
> Should we actually do this bit now?

I do not see the need to do this now. Moreover, I suggest we look to make the Mac code use a CGPattern as we do for iOS. This will achieve the same effect as the FIXME above (to have the Mac and iOS code paths use CG objects and operations) and will allow us to remove an earlier FIXME in this function: <https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm?rev=221485#L304>.

[Daniel Bates]

Committed r222065: <http://trac.webkit.org/changeset/222065>