Bug 178557 - Enable gigacage on iOS with a 32GB runway and ensure it doesn't break WasmBench
Summary: Enable gigacage on iOS with a 32GB runway and ensure it doesn't break WasmBench
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
: 177605 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-10-19 19:09 PDT by Saam Barati
Modified: 2017-12-08 14:29 PST (History)
13 users (show)

See Also:

Attachments
patch (3.38 KB, patch)
2017-12-07 12:47 PST, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (3.72 KB, patch)
2017-12-07 13:05 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (4.22 KB, patch)
2017-12-07 13:09 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (4.27 KB, patch)
2017-12-07 13:12 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (3.99 KB, patch)
2017-12-07 13:13 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (3.99 KB, patch)
2017-12-07 13:24 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-10-19 19:09:51 PDT 
...
Comment 1 Saam Barati 2017-12-07 11:49:31 PST 
Patch forthcoming.
Comment 2 Saam Barati 2017-12-07 11:59:08 PST 
*** Bug 177605 has been marked as a duplicate of this bug. ***
Comment 3 Saam Barati 2017-12-07 12:47:11 PST 
Created attachment 328718 [details]
patch

I think this should do it. But we'll see what EWS says w.r.t building on other platforms.
Comment 4 Mark Lam 2017-12-07 12:57:19 PST 
Comment on attachment 328718 [details]
patch

r=me
Comment 5 Saam Barati 2017-12-07 13:05:05 PST 
Created attachment 328720 [details]
patch for landing

Curious why static assert is failing on x86-32. I made the static assert have a better error message.
Comment 6 Saam Barati 2017-12-07 13:09:57 PST 
Created attachment 328722 [details]
patch for landing

Fix 32-bit compiles since size_t is 32-bit on 32-bit platforms.
Comment 7 Saam Barati 2017-12-07 13:12:25 PST 
Created attachment 328724 [details]
patch for landing
Comment 8 Saam Barati 2017-12-07 13:13:56 PST 
Created attachment 328725 [details]
patch for landing
Comment 9 Saam Barati 2017-12-07 13:24:33 PST 
Created attachment 328728 [details]
patch for landing
Comment 10 WebKit Commit Bot 2017-12-08 14:28:34 PST 
Comment on attachment 328728 [details]
patch for landing

Clearing flags on attachment: 328728

Committed r225701: <https://trac.webkit.org/changeset/225701>
Comment 11 WebKit Commit Bot 2017-12-08 14:28:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2017-12-08 14:29:36 PST 
<rdar://problem/35943687>