Bug 178513 – Support ::before/::after pseudo elements on elements with display:contents

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

div { display:contents }
div::after { content: 'foo' }

should work.

[Antti Koivisto]

Created attachment 324225 [details]
patch

[Build Bot]

Comment on attachment 324225 [details]
patch

Attachment 324225 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4919908

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 324237 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Antti Koivisto]

Created attachment 324259 [details]
patch

[Build Bot]

Comment on attachment 324259 [details]
patch

Attachment 324259 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4922877

New failing tests:
fast/dom/offset-parent-positioned-and-inline.html
platform/ios/ios/plugin/youtube-flash-plugin-iframe.html
platform/ios/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width.html
security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html
imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html
fast/replaced/replaced-child-of-absolute-with-auto-height.html
security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html
compositing/geometry/repaint-foreground-layer.html

[Build Bot]

Created attachment 324290 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Build Bot]

Comment on attachment 324259 [details]
patch

Attachment 324259 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4923397

New failing tests:
fullscreen/full-screen-fixed-pos-parent.html
fast/repaint/text-in-relative-positioned-inline.html
security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html
imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html
security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html
security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html
fast/forms/select-listbox-focus-displaynone.html

[Build Bot]

Created attachment 324293 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 324259 [details]
patch

Attachment 324259 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4923616

New failing tests:
fullscreen/full-screen-fixed-pos-parent.html
fast/repaint/text-in-relative-positioned-inline.html
security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html
imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html
security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html
security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html
fast/forms/select-listbox-focus-displaynone.html

[Build Bot]

Created attachment 324295 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 324299 [details]
patch

[Build Bot]

Comment on attachment 324299 [details]
patch

Attachment 324299 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4925825

New failing tests:
security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html
security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html
security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html

[Build Bot]

Created attachment 324319 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 324299 [details]
patch

Attachment 324299 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4925646

New failing tests:
fast/dom/offset-parent-positioned-and-inline.html
platform/ios/ios/plugin/youtube-flash-plugin-iframe.html
platform/ios/ios/plugin/youtube-flash-plugin-iframe-no-height-or-width.html
security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html
fast/replaced/replaced-child-of-absolute-with-auto-height.html
security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html
compositing/geometry/repaint-foreground-layer.html

[Build Bot]

Created attachment 324321 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Build Bot]

Comment on attachment 324299 [details]
patch

Attachment 324299 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4926007

New failing tests:
security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html
security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html
security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html

[Build Bot]

Created attachment 324324 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 324366 [details]
patch

[Ryosuke Niwa]

Comment on attachment 324366 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324366&action=review

> Source/WebCore/style/RenderTreePosition.cpp:89
> +    auto initializeStack = [&] {

I think it's cleaner to just have to code instead of creating a closure & calling it immediately.
I thought you were trying to call this lazily or something.

> Source/WebCore/style/RenderTreePosition.cpp:105
> +    auto begin = [&] {

I think begin() doesn't really covey the semantics. Please give it a more descriptive name.
findFirstRendererConsideringBeforePseudoElement?

> Source/WebCore/style/RenderTreePosition.cpp:109
> +                if (host != parentElement)

It's not clear what host != parentElement means.
Maybe you can define a local boolean with a descriptive name or add a one line comment to clarify what it means?

> Source/WebCore/style/RenderTreePosition.cpp:122
> +    auto push = [&] (Element& element) -> RenderElement* {

Can we give this a more descriptive name like pushIfBeforePseudoElementExists?

> Source/WebCore/style/RenderTreePosition.cpp:132
> +    auto pop = [&] (unsigned depth) -> RenderElement* {

Can we call this popUntilAfterPseudoElement or something to make the semantics clear?
pop(it.depth()) looks rather mysterious.

[Antti Koivisto]

https://trac.webkit.org/r223748

[Radar WebKit Bug Importer]

<rdar://problem/35517845>