RESOLVED FIXED 178338
[JSC] We should have the op_in_by_id and op_in_by_val for "in" operations 
https://bugs.webkit.org/show_bug.cgi?id=178338
Summary [JSC] We should have the op_in_by_id and op_in_by_val for "in" operations
Caio Lima
Reported 2017-10-16 05:59:12 PDT
Nowadays we just have "op_in" byte code that behaves much like "op_bet_by_val" bytecode. However the pattern ```"prop" in obj``` can be likely present in modern code, mainly on built-in functions like Object.prototype.defineProperty[1]. In Object.prototype.defineProperty case for instance, we could perform some more aggressive optimizations to enable Allocation Sinking and get speedups on relevant frameworks that uses this function (e.g Ember.js). The idea here is to follow the same architecture used on "op_get_by_id" and be less conservative on DFG + FTL "op_in" compilation. One advantage that I have in mind right now is that we could compile IC as DFG nodes such as we perform on GetById. [1] - https://bugs.webkit.org/show_bug.cgi?id=172888
Attachments
Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2020-06-02 04:40:37 PDT
This is already implemented.
Note You need to log in before you can comment on or make changes to this bug.