Bug 172888 – [JSC] Create a fast path to Object.defineProperty

• Status: NEW
• Component: JavaScriptCore

[Caio Lima]

We can create a fast path to Object.defineProperty to get improvements due Object Allocation Sink

[Yusuke Suzuki]

The following is the design in my mind

We can find that Object.defineProperty is frequently called in some realistic frameworks such as Ember.js.
Object.defineProperty is typically used in the following form.

Object.defineProperty(object, name, {
    // property descriptor object
});

If we can create Object.defineProperty's prologue in JS, we can encourage Object Allocation Sinking to sink the above property descriptor object.
My design is simple. We already have some bytecodes like op_define_data_property / op_define_accessor_property.
So, let's add bytecode intrinsic for them and wrap them with JS function.

function defineProperty(object, name, descriptor) {
    // Retrieve necessary values.
    var enumerable = descriptor.enumerable;
    ...
    // And call intrinsics.
    if (accessor property)
        @defineAccessorProperty(...);
    else
        @defineDataProperty(...);
    ....
}

[Yusuke Suzuki]

(In reply to Yusuke Suzuki from comment #1)
> The following is the design in my mind
> 
> We can find that Object.defineProperty is frequently called in some
> realistic frameworks such as Ember.js.
> Object.defineProperty is typically used in the following form.
> 
> Object.defineProperty(object, name, {
>     // property descriptor object
> });
> 
> If we can create Object.defineProperty's prologue in JS, we can encourage
> Object Allocation Sinking to sink the above property descriptor object.
> My design is simple. We already have some bytecodes like
> op_define_data_property / op_define_accessor_property.
> So, let's add bytecode intrinsic for them and wrap them with JS function.
> 
> function defineProperty(object, name, descriptor) {
>     // Retrieve necessary values.
>     var enumerable = descriptor.enumerable;
>     ...
>     // And call intrinsics.
>     if (accessor property)
>         @defineAccessorProperty(...);
>     else
>         @defineDataProperty(...);
>     ....
> }

At that time, we need extra carefully construct this defineProperty function to be inlined.

[Caio Lima]

WIP. Patch coming soon.

[Caio Lima]

Created attachment 315614 [details]
Simple benchmark

Just a microbenchmark to see the speedup in this operation.

[Caio Lima]

Created attachment 315616 [details]
WIP - It starts

RFC here. It is just starting the implementation.

This implementation isn't spec compliant and I'm thinking create intrinsic functions to verify if the descriptor has some property without user observable behavior, otherwise it will be classified as escaped object if we use "in" operation.

I'm also in doubt if there is another case where the user-observable behavior can be captured other than proxies case, because according the spec[1], ToPropertyDescriptor operation is called.

The fast case I'm planing here is when we have "Object.defineProperty(a, "foo", {/* descriptor */})" and descriptor is a JS Object allocated in DFG with "NewObject".

[1]-https://tc39.github.io/ecma262/#sec-object.defineproperty

[Build Bot]

Attachment 315616 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:827:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 315616 [details]
WIP - It starts

Attachment 315616 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/4131901

New failing tests:
ChakraCore.yaml/ChakraCore/test/es5/InsufficientArguments.js.default
jsc-layout-tests.yaml/js/script-tests/function-toString-vs-name.js.layout-ftl-no-cjit
jsc-layout-tests.yaml/js/script-tests/function-toString-vs-name.js.layout-dfg-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/array-defineOwnProperty.js.layout
jsc-layout-tests.yaml/js/script-tests/array-defineOwnProperty.js.layout-dfg-eager-no-cjit
ChakraCore.yaml/ChakraCore/test/es5/enumerable.js.default
stress/array-species-functions.js.ftl-eager
jsc-layout-tests.yaml/js/script-tests/function-toString-vs-name.js.layout-no-cjit
jsc-layout-tests.yaml/js/script-tests/function-toString-vs-name.js.layout-no-ftl
stress/array-species-functions.js.no-llint
stress/array-species-functions.js.dfg-maximal-flush-validate-no-cjit
stress/array-species-functions.js.no-cjit-validate-phases
stress/array-species-functions.js.ftl-eager-no-cjit-b3o1
stress/array-species-functions.js.no-ftl
stress/array-species-functions.js.ftl-no-cjit-no-put-stack-validate
ChakraCore.yaml/ChakraCore/test/es6/proxyprotobug.js.default
stress/array-species-functions.js.no-cjit-collect-continuously
jsc-layout-tests.yaml/js/script-tests/function-toString-vs-name.js.layout-ftl-eager-no-cjit
stress/array-species-functions.js.ftl-no-cjit-b3o1
stress/array-species-functions.js.dfg-eager-no-cjit-validate
jsc-layout-tests.yaml/js/script-tests/array-defineOwnProperty.js.layout-no-cjit
ChakraCore.yaml/ChakraCore/test/es5/defineProperty.js.default
stress/array-species-functions.js.default
jsc-layout-tests.yaml/js/script-tests/array-defineOwnProperty.js.layout-ftl-no-cjit
stress/array-species-functions.js.ftl-no-cjit-validate-sampling-profiler
ChakraCore.yaml/ChakraCore/test/es5/defineIndexProperty.js.default
stress/array-species-functions.js.dfg-eager
jsc-layout-tests.yaml/js/script-tests/function-toString-vs-name.js.layout
stress/array-species-functions.js.ftl-eager-no-cjit
stress/array-species-functions.js.ftl-no-cjit-small-pool
stress/array-species-functions.js.ftl-no-cjit-no-inline-validate
jsc-layout-tests.yaml/js/script-tests/array-defineOwnProperty.js.layout-ftl-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/array-defineOwnProperty.js.layout-no-llint
jsc-layout-tests.yaml/js/script-tests/function-toString-vs-name.js.layout-no-llint
jsc-layout-tests.yaml/js/script-tests/array-defineOwnProperty.js.layout-no-ftl

[Build Bot]

Comment on attachment 315616 [details]
WIP - It starts

Attachment 315616 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4131930

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315620 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315616 [details]
WIP - It starts

Attachment 315616 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4131956

New failing tests:
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker.html
streams/shadowing-defineProperty.html
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html
imported/w3c/web-platform-tests/streams/piping/general.html
js/dom/Object-defineProperty.html
imported/w3c/web-platform-tests/streams/count-queuing-strategy.dedicatedworker.html
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.dedicatedworker.html
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.dedicatedworker.html
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.html
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.dedicatedworker.html
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.dedicatedworker.html
imported/w3c/web-platform-tests/streams/piping/flow-control.dedicatedworker.html
streams/reference-implementation/count-queuing-strategy.html
js/function-toString-vs-name.html
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.dedicatedworker.html
streams/reference-implementation/byte-length-queuing-strategy.html
js/array-defineOwnProperty.html
imported/w3c/web-platform-tests/streams/piping/flow-control.html
imported/w3c/web-platform-tests/streams/count-queuing-strategy.html

[Build Bot]

Created attachment 315621 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315616 [details]
WIP - It starts

Attachment 315616 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4131974

New failing tests:
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker.html
streams/shadowing-defineProperty.html
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.dedicatedworker.html
js/dom/Object-defineProperty.html
imported/w3c/web-platform-tests/streams/count-queuing-strategy.dedicatedworker.html
imported/w3c/web-platform-tests/streams/piping/general.html
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.dedicatedworker.html
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.html
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.dedicatedworker.html
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.dedicatedworker.html
imported/w3c/web-platform-tests/streams/piping/flow-control.dedicatedworker.html
streams/reference-implementation/count-queuing-strategy.html
js/function-toString-vs-name.html
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.dedicatedworker.html
streams/reference-implementation/byte-length-queuing-strategy.html
js/array-defineOwnProperty.html
imported/w3c/web-platform-tests/streams/piping/flow-control.html
imported/w3c/web-platform-tests/streams/count-queuing-strategy.html

[Build Bot]

Created attachment 315625 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Build Bot]

Comment on attachment 315616 [details]
WIP - It starts

Attachment 315616 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4132053

New failing tests:
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker.html
streams/shadowing-defineProperty.html
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html
imported/w3c/web-platform-tests/streams/piping/general.html
js/dom/Object-defineProperty.html
imported/w3c/web-platform-tests/streams/count-queuing-strategy.dedicatedworker.html
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.dedicatedworker.html
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.dedicatedworker.html
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.html
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.dedicatedworker.html
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.dedicatedworker.html
imported/w3c/web-platform-tests/streams/piping/flow-control.dedicatedworker.html
streams/reference-implementation/count-queuing-strategy.html
js/function-toString-vs-name.html
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.dedicatedworker.html
streams/reference-implementation/byte-length-queuing-strategy.html
js/array-defineOwnProperty.html
imported/w3c/web-platform-tests/streams/piping/flow-control.html
imported/w3c/web-platform-tests/streams/count-queuing-strategy.html

[Build Bot]

Created attachment 315626 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Caio Lima]

Created attachment 317382 [details]
RFC - Patch proposal

It's a WIP. Not all test passing, but I would like to get feedback in the Path I'm following here. I'm not 100% sure if the Machinery into FTL analysis are right.

The main idea into FTL is that since the descriptor allocation won't exist, I need to check the presence of properties from structure.

Also, I think that fast path rule should allow just descriptors with prototype === Object. Otherwise it should fall to slow path, since we can have proxies into prototype chain.

[Caio Lima]

Created attachment 322641 [details]
Patch

[Caio Lima]

Created attachment 322642 [details]
Benchmarks

These are the results of current benchmarks. I can see some regressions on "regexp-prototype-*-observable-side-effects" and "string-prototype-*-observable-side-effects", but as the function is called 4 times in each test, there is no JIT and we can't benefit from it.

[Build Bot]

Comment on attachment 322641 [details]
Patch

Attachment 322641 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4755956

New failing tests:
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker.html
ietestcenter/Javascript/15.2.3.6-3-5.html
ietestcenter/Javascript/15.2.3.6-3-11.html
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html
ietestcenter/Javascript/15.2.3.6-3-14.html
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.dedicatedworker.html
js/dom/Object-defineProperty.html
imported/w3c/web-platform-tests/streams/count-queuing-strategy.dedicatedworker.html
ietestcenter/Javascript/15.2.3.6-3-10.html
streams/shadowing-defineProperty.html
imported/w3c/web-platform-tests/streams/piping/general.html
ietestcenter/Javascript/15.2.3.6-3-12.html
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.dedicatedworker.html
ietestcenter/Javascript/15.2.3.6-3-7.html
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.html
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.html
ietestcenter/Javascript/15.2.3.6-3-8.html
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.dedicatedworker.html
ietestcenter/Javascript/15.2.3.6-3-9.html
imported/w3c/web-platform-tests/streams/piping/flow-control.dedicatedworker.html
streams/reference-implementation/count-queuing-strategy.html
ietestcenter/Javascript/15.2.3.6-3-13.html
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.dedicatedworker.html
streams/reference-implementation/byte-length-queuing-strategy.html
ietestcenter/Javascript/15.2.3.6-3-6.html
imported/w3c/web-platform-tests/streams/piping/flow-control.html
imported/w3c/web-platform-tests/streams/count-queuing-strategy.html

[Build Bot]

Created attachment 322697 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 322641 [details]
Patch

Attachment 322641 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4757981

New failing tests:
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker.html
ietestcenter/Javascript/15.2.3.6-3-5.html
ietestcenter/Javascript/15.2.3.6-3-11.html
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html
ietestcenter/Javascript/15.2.3.6-3-14.html
imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.dedicatedworker.html
js/dom/Object-defineProperty.html
imported/w3c/web-platform-tests/streams/count-queuing-strategy.dedicatedworker.html
ietestcenter/Javascript/15.2.3.6-3-10.html
streams/shadowing-defineProperty.html
imported/w3c/web-platform-tests/streams/piping/general.html
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.dedicatedworker.html
ietestcenter/Javascript/15.2.3.6-3-12.html
ietestcenter/Javascript/15.2.3.6-3-7.html
imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.html
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.html
ietestcenter/Javascript/15.2.3.6-3-8.html
imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.dedicatedworker.html
ietestcenter/Javascript/15.2.3.6-3-9.html
imported/w3c/web-platform-tests/streams/piping/flow-control.dedicatedworker.html
streams/reference-implementation/count-queuing-strategy.html
ietestcenter/Javascript/15.2.3.6-3-13.html
imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.html
imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.dedicatedworker.html
streams/reference-implementation/byte-length-queuing-strategy.html
ietestcenter/Javascript/15.2.3.6-3-6.html
imported/w3c/web-platform-tests/streams/piping/flow-control.html
imported/w3c/web-platform-tests/streams/count-queuing-strategy.html

[Build Bot]

Created attachment 322727 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Caio Lima]

Created attachment 322736 [details]
Patch

[Build Bot]

Comment on attachment 322736 [details]
Patch

Attachment 322736 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4759348

New failing tests:
ietestcenter/Javascript/15.2.3.6-3-10.html
ietestcenter/Javascript/15.2.3.6-3-8.html
ietestcenter/Javascript/15.2.3.6-3-9.html
ietestcenter/Javascript/15.2.3.6-3-5.html
ietestcenter/Javascript/15.2.3.6-3-12.html
ietestcenter/Javascript/15.2.3.6-3-7.html
ietestcenter/Javascript/15.2.3.6-3-14.html
ietestcenter/Javascript/15.2.3.6-3-13.html
js/dom/Object-defineProperty.html
ietestcenter/Javascript/15.2.3.6-3-6.html
ietestcenter/Javascript/15.2.3.6-3-11.html

[Build Bot]

Created attachment 322743 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 322736 [details]
Patch

Attachment 322736 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4759749

New failing tests:
ietestcenter/Javascript/15.2.3.6-3-10.html
ietestcenter/Javascript/15.2.3.6-3-8.html
ietestcenter/Javascript/15.2.3.6-3-9.html
ietestcenter/Javascript/15.2.3.6-3-5.html
ietestcenter/Javascript/15.2.3.6-3-12.html
ietestcenter/Javascript/15.2.3.6-3-7.html
ietestcenter/Javascript/15.2.3.6-3-14.html
ietestcenter/Javascript/15.2.3.6-3-13.html
js/dom/Object-defineProperty.html
ietestcenter/Javascript/15.2.3.6-3-6.html
ietestcenter/Javascript/15.2.3.6-3-11.html

[Build Bot]

Created attachment 322749 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 322736 [details]
Patch

Attachment 322736 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4759773

New failing tests:
ietestcenter/Javascript/15.2.3.6-3-10.html
ietestcenter/Javascript/15.2.3.6-3-8.html
ietestcenter/Javascript/15.2.3.6-3-9.html
ietestcenter/Javascript/15.2.3.6-3-5.html
ietestcenter/Javascript/15.2.3.6-3-12.html
ietestcenter/Javascript/15.2.3.6-3-7.html
ietestcenter/Javascript/15.2.3.6-3-14.html
ietestcenter/Javascript/15.2.3.6-3-13.html
js/dom/Object-defineProperty.html
ietestcenter/Javascript/15.2.3.6-3-6.html
ietestcenter/Javascript/15.2.3.6-3-11.html

[Build Bot]

Created attachment 322751 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Build Bot]

Comment on attachment 322736 [details]
Patch

Attachment 322736 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4760307

New failing tests:
ietestcenter/Javascript/15.2.3.6-3-10.html
ietestcenter/Javascript/15.2.3.6-3-8.html
ietestcenter/Javascript/15.2.3.6-3-9.html
ietestcenter/Javascript/15.2.3.6-3-5.html
ietestcenter/Javascript/15.2.3.6-3-12.html
ietestcenter/Javascript/15.2.3.6-3-7.html
ietestcenter/Javascript/15.2.3.6-3-14.html
ietestcenter/Javascript/15.2.3.6-3-13.html
js/dom/Object-defineProperty.html
ietestcenter/Javascript/15.2.3.6-3-6.html
ietestcenter/Javascript/15.2.3.6-3-11.html

[Build Bot]

Created attachment 322754 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Caio Lima]

Created attachment 322822 [details]
Patch

[Build Bot]

Comment on attachment 322822 [details]
Patch

Attachment 322822 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4766568

New failing tests:
js/dom/Object-defineProperty.html
ietestcenter/Javascript/15.2.3.6-3-8.html
ietestcenter/Javascript/15.2.3.6-3-13.html

[Build Bot]

Created attachment 322826 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 322822 [details]
Patch

Attachment 322822 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4766583

New failing tests:
js/dom/Object-defineProperty.html
ietestcenter/Javascript/15.2.3.6-3-8.html
ietestcenter/Javascript/15.2.3.6-3-13.html

[Build Bot]

Created attachment 322827 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 322822 [details]
Patch

Attachment 322822 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4766600

New failing tests:
js/dom/Object-defineProperty.html
ietestcenter/Javascript/15.2.3.6-3-8.html
ietestcenter/Javascript/15.2.3.6-3-13.html

[Build Bot]

Created attachment 322831 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 322822 [details]
Patch

Attachment 322822 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4766715

New failing tests:
js/dom/Object-defineProperty.html
ietestcenter/Javascript/15.2.3.6-3-8.html
ietestcenter/Javascript/15.2.3.6-3-13.html

[Build Bot]

Created attachment 322832 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Caio Lima]

Created attachment 322839 [details]
Patch

[Build Bot]

Comment on attachment 322839 [details]
Patch

Attachment 322839 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4768418

New failing tests:
accessibility/ios-simulator/video-elements-ios.html

[Build Bot]

Created attachment 322846 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Maciej Stachowiak]

Comment on attachment 322839 [details]
Patch

Unfortunately, this old patch no longer applies.

[Maciej Stachowiak]

(Perf wins are good of course, if this is still relevant.)