Bug 178154 - Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
Summary: Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 124391
  Show dependency tree / graph
 
Reported: 2017-10-10 19:49 PDT by Ryosuke Niwa
Modified: 2017-10-10 21:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (20.38 KB, patch)
2017-10-10 20:12 PDT, Ryosuke Niwa 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-10-10 19:49:03 PDT 
Enable custom pasteboard on macOS and iOS inside DumpRenderTree and WebKitTestRunner
so that we can test the shipping configuration in Safari in our tests.
Comment 1 Ryosuke Niwa 2017-10-10 20:12:16 PDT 
Created attachment 323375 [details]
Patch
Comment 2 Build Bot 2017-10-10 20:14:36 PDT 
Attachment 323375 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:195:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Wenson Hsieh 2017-10-10 20:50:46 PDT 
Comment on attachment 323375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323375&action=review

> Source/WebCore/platform/cocoa/PasteboardCocoa.mm:198
> +        if (existingMIMEs.contains(mimeType))

Nice catch!

> Source/WebKit/ChangeLog:8
> +        Plumed customPasteboardDataEnabled flag to be used in WebKitTestRunner.

*Plumbed
Comment 4 Ryosuke Niwa 2017-10-10 21:10:11 PDT 
Thanks for the review!

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 323375 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=323375&action=review
> 
> > Source/WebCore/platform/cocoa/PasteboardCocoa.mm:198
> > +        if (existingMIMEs.contains(mimeType))
> 
> Nice catch!
> 
> > Source/WebKit/ChangeLog:8
> > +        Plumed customPasteboardDataEnabled flag to be used in WebKitTestRunner.
> 
> *Plumbed

Will fix.
Comment 5 Ryosuke Niwa 2017-10-10 21:12:32 PDT 
Committed r223167: <http://trac.webkit.org/changeset/223167>
Comment 6 Radar WebKit Bug Importer 2017-10-10 21:13:16 PDT 
<rdar://problem/34926645>