RESOLVED FIXED 178154
Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner 
https://bugs.webkit.org/show_bug.cgi?id=178154
Summary Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
Ryosuke Niwa
Reported 2017-10-10 19:49:03 PDT
Enable custom pasteboard on macOS and iOS inside DumpRenderTree and WebKitTestRunner so that we can test the shipping configuration in Safari in our tests.
Attachments
Patch (20.38 KB, patch)
2017-10-10 20:12 PDT, Ryosuke Niwa 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-10-10 20:12:16 PDT
Created attachment 323375 [details] Patch
Build Bot
Comment 2 2017-10-10 20:14:36 PDT
Attachment 323375 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:195: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Wenson Hsieh
Comment 3 2017-10-10 20:50:46 PDT
Comment on attachment 323375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323375&action=review > Source/WebCore/platform/cocoa/PasteboardCocoa.mm:198 > + if (existingMIMEs.contains(mimeType)) Nice catch! > Source/WebKit/ChangeLog:8 > + Plumed customPasteboardDataEnabled flag to be used in WebKitTestRunner. *Plumbed
Ryosuke Niwa
Comment 4 2017-10-10 21:10:11 PDT
Thanks for the review! (In reply to Wenson Hsieh from comment #3) > Comment on attachment 323375 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=323375&action=review > > > Source/WebCore/platform/cocoa/PasteboardCocoa.mm:198 > > + if (existingMIMEs.contains(mimeType)) > > Nice catch! > > > Source/WebKit/ChangeLog:8 > > + Plumed customPasteboardDataEnabled flag to be used in WebKitTestRunner. > > *Plumbed Will fix.
Ryosuke Niwa
Comment 5 2017-10-10 21:12:32 PDT
Committed r223167: <http://trac.webkit.org/changeset/223167>
Radar WebKit Bug Importer
Comment 6 2017-10-10 21:13:16 PDT
<rdar://problem/34926645>
Note You need to log in before you can comment on or make changes to this bug.