Bug 178118 – Loading should be disabled while constructing the fragment in WebContentReader::readWebArchive

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

This cleanup is needed in order to start using blob URLs instead of overriding document loaders.

[Ryosuke Niwa]

Created attachment 323288 [details]
Cleanup

[Ryosuke Niwa]

This patch should improve the reliability of some of these editing tests.

[Ryosuke Niwa]

Created attachment 323290 [details]
Fixed builds

[Build Bot]

Comment on attachment 323290 [details]
Fixed builds

Attachment 323290 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4810684

New failing tests:
editing/selection/drag-to-contenteditable-iframe.html

[Build Bot]

Created attachment 323296 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Ryosuke Niwa]

(In reply to Build Bot from comment #4)
> Comment on attachment 323290 [details]
> Fixed builds
> 
> Attachment 323290 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/4810684
> 
> New failing tests:
> editing/selection/drag-to-contenteditable-iframe.html

That's odd... this test is supposed to be ignored on iOS...

[Ryosuke Niwa]

Created attachment 323325 [details]
Skip the drag & drop test on iOS

[Antti Koivisto]

Comment on attachment 323325 [details]
Skip the drag & drop test on iOS

r=me

[Chris Dumez]

Comment on attachment 323325 [details]
Skip the drag & drop test on iOS

r=me

[Alexey Proskuryakov]

Comment on attachment 323325 [details]
Skip the drag & drop test on iOS

View in context: https://bugs.webkit.org/attachment.cgi?id=323325&action=review

> LayoutTests/platform/ios/TestExpectations:241
>  # Drag-and-drop is not supported:
>  editing/pasteboard/datatransfer-items-drop-plaintext-file.html
>  editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html
> +editing/selection/drag-to-contenteditable-iframe.html

We should really have all of these marked with WontFix (or Skipped if WontFix is not true). It's mostly legacy lines that don't have any expectation spelled out.

[Ryosuke Niwa]

(In reply to Alexey Proskuryakov from comment #10)
> Comment on attachment 323325 [details]
> Skip the drag & drop test on iOS
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=323325&action=review
> 
> > LayoutTests/platform/ios/TestExpectations:241
> >  # Drag-and-drop is not supported:
> >  editing/pasteboard/datatransfer-items-drop-plaintext-file.html
> >  editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html
> > +editing/selection/drag-to-contenteditable-iframe.html
> 
> We should really have all of these marked with WontFix (or Skipped if
> WontFix is not true). It's mostly legacy lines that don't have any
> expectation spelled out.

Sure, I'll add [ Skip ].

[Ryosuke Niwa]

Committed r223140: <http://trac.webkit.org/changeset/223140>

[Radar WebKit Bug Importer]

<rdar://problem/34918607>