Bug 178081 - [WPE][GTK] Propagate libepoxy compiler flags obtained from pkg-config
Summary: [WPE][GTK] Propagate libepoxy compiler flags obtained from pkg-config
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
Keywords: InRadar
Depends on:
Reported: 2017-10-09 08:16 PDT by Adrian Perez
Modified: 2017-10-09 09:05 PDT (History)
9 users (show)

See Also:

Patch (3.65 KB, patch)
2017-10-09 08:21 PDT, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-10-09 08:16:23 PDT
Similarly to what was done for bug #175125, we should use the
value of the “Cflags” field from “epoxy.pc”. In most cases it
will be empty, but the correct thing is respecting it.

Example: changes like https://github.com/anholt/libepoxy/pull/113
may result in the “Cflags” field being populated, and it's better
to make WebKit pick its value that being bitten by build failures
in the future and/or in less desktop-y platforms.
Comment 1 Adrian Perez 2017-10-09 08:21:09 PDT
Created attachment 323175 [details]
Comment 2 WebKit Commit Bot 2017-10-09 09:04:43 PDT
Comment on attachment 323175 [details]

Clearing flags on attachment: 323175

Committed r223045: <http://trac.webkit.org/changeset/223045>
Comment 3 WebKit Commit Bot 2017-10-09 09:04:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-10-09 09:05:19 PDT