Bug 177857 – [WPE] Expose ENABLE_XSLT option

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Michael Catanzaro]

Expose ENABLE_XSLT option

[Michael Catanzaro]

Created attachment 322640 [details]
Patch

[Carlos Alberto Lopez Perez]

Why we want to expose this?

[Adrian Perez]

(In reply to Carlos Alberto Lopez Perez from comment #2)
> Why we want to expose this?

Saving some MiB of disk space and some memory usage seems worth it, 
particularly for embedded usage.

Example: The Arch Linux x86-64 libxml2+libxslt packages take ~11.5 MiB
on disk, and take at least ~1.6 MiB of memory when loaded (according to
Bloaty — https://github.com/google/bloaty), plus the reductions of size
from the WebKit code that implements the XSLT functionality.

[Michael Catanzaro]

I'm fine with requiring libxslt, but it seems useful for WPE to expose options for disabling features that add new dependencies if those dependencies are not useful on embedded devices.

Anyway, if we don't expose it, we should revert r222727.

[Carlos Alberto Lopez Perez]

(In reply to Adrian Perez from comment #3)
> (In reply to Carlos Alberto Lopez Perez from comment #2)
> > Why we want to expose this?
> 
> Saving some MiB of disk space and some memory usage seems worth it, 
> particularly for embedded usage.
> 
> Example: The Arch Linux x86-64 libxml2+libxslt packages take ~11.5 MiB
> on disk, and take at least ~1.6 MiB of memory when loaded (according to
> Bloaty — https://github.com/google/bloaty), plus the reductions of size
> from the WebKit code that implements the XSLT functionality.

Ok..

That's something someone might want to do in order to optimize space/memory requirements as much as possible.

Let's do this then

[Carlos Alberto Lopez Perez]

Comment on attachment 322640 [details]
Patch

Ok

[WebKit Commit Bot]

Comment on attachment 322640 [details]
Patch

Clearing flags on attachment: 322640

Committed r223152: <http://trac.webkit.org/changeset/223152>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.