Bug 177857 - [WPE] Expose ENABLE_XSLT option
Summary: [WPE] Expose ENABLE_XSLT option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-04 02:11 PDT by Michael Catanzaro
Modified: 2017-10-10 15:59 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.21 KB, patch)
2017-10-04 02:12 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-10-04 02:11:25 PDT
Expose ENABLE_XSLT option
Comment 1 Michael Catanzaro 2017-10-04 02:12:28 PDT
Created attachment 322640 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2017-10-10 12:09:44 PDT
Why we want to expose this?
Comment 3 Adrian Perez 2017-10-10 13:49:27 PDT
(In reply to Carlos Alberto Lopez Perez from comment #2)
> Why we want to expose this?

Saving some MiB of disk space and some memory usage seems worth it, 
particularly for embedded usage.

Example: The Arch Linux x86-64 libxml2+libxslt packages take ~11.5 MiB
on disk, and take at least ~1.6 MiB of memory when loaded (according to
Bloaty — https://github.com/google/bloaty), plus the reductions of size
from the WebKit code that implements the XSLT functionality.
Comment 4 Michael Catanzaro 2017-10-10 13:56:56 PDT
I'm fine with requiring libxslt, but it seems useful for WPE to expose options for disabling features that add new dependencies if those dependencies are not useful on embedded devices.

Anyway, if we don't expose it, we should revert r222727.
Comment 5 Carlos Alberto Lopez Perez 2017-10-10 15:29:42 PDT
(In reply to Adrian Perez from comment #3)
> (In reply to Carlos Alberto Lopez Perez from comment #2)
> > Why we want to expose this?
> 
> Saving some MiB of disk space and some memory usage seems worth it, 
> particularly for embedded usage.
> 
> Example: The Arch Linux x86-64 libxml2+libxslt packages take ~11.5 MiB
> on disk, and take at least ~1.6 MiB of memory when loaded (according to
> Bloaty — https://github.com/google/bloaty), plus the reductions of size
> from the WebKit code that implements the XSLT functionality.

Ok..

That's something someone might want to do in order to optimize space/memory requirements as much as possible.

Let's do this then
Comment 6 Carlos Alberto Lopez Perez 2017-10-10 15:29:50 PDT
Comment on attachment 322640 [details]
Patch

Ok
Comment 7 WebKit Commit Bot 2017-10-10 15:59:11 PDT
Comment on attachment 322640 [details]
Patch

Clearing flags on attachment: 322640

Committed r223152: <http://trac.webkit.org/changeset/223152>
Comment 8 WebKit Commit Bot 2017-10-10 15:59:13 PDT
All reviewed patches have been landed.  Closing bug.