libxslt is not a hard dep.
Created attachment 322387 [details] Patch
Comment on attachment 322387 [details] Patch Clearing flags on attachment: 322387 Committed r222727: <http://trac.webkit.org/changeset/222727>
All reviewed patches have been landed. Closing bug.
I suppose we should expose ENABLE_XSLT as a public option, since it allows avoiding a dependency that's not needed on embedded devices.
(In reply to Michael Catanzaro from comment #4) > I suppose we should expose ENABLE_XSLT as a public option, since it allows > avoiding a dependency that's not needed on embedded devices. Yes, I think that makes sense.
(In reply to Zan Dobersek from comment #5) > (In reply to Michael Catanzaro from comment #4) > > I suppose we should expose ENABLE_XSLT as a public option, since it allows > > avoiding a dependency that's not needed on embedded devices. > > Yes, I think that makes sense. +1
(In reply to Adrian Perez from comment #6) > (In reply to Zan Dobersek from comment #5) > > (In reply to Michael Catanzaro from comment #4) > > > I suppose we should expose ENABLE_XSLT as a public option, since it allows > > > avoiding a dependency that's not needed on embedded devices. > > > > Yes, I think that makes sense. > > +1 Please do. We want to remove libxslt from WinCairo by default
This doesn't affect WinCairo at all since the choice of which options to expose for WPE is WPE-specific.
Bug #177857
In the future: please no patches to allow disabling dependencies unless the corresponding feature flag also made public.