Bug 177752 – [WPE] Do not require XSLT if disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Olivier Blin]

libxslt is not a hard dep.

[Olivier Blin]

Created attachment 322387 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 322387 [details]
Patch

Clearing flags on attachment: 322387

Committed r222727: <http://trac.webkit.org/changeset/222727>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

I suppose we should expose ENABLE_XSLT as a public option, since it allows avoiding a dependency that's not needed on embedded devices.

[Zan Dobersek]

(In reply to Michael Catanzaro from comment #4)
> I suppose we should expose ENABLE_XSLT as a public option, since it allows
> avoiding a dependency that's not needed on embedded devices.

Yes, I think that makes sense.

[Adrian Perez]

(In reply to Zan Dobersek from comment #5)
> (In reply to Michael Catanzaro from comment #4)
> > I suppose we should expose ENABLE_XSLT as a public option, since it allows
> > avoiding a dependency that's not needed on embedded devices.
> 
> Yes, I think that makes sense.

+1

[Don Olmstead]

(In reply to Adrian Perez from comment #6)
> (In reply to Zan Dobersek from comment #5)
> > (In reply to Michael Catanzaro from comment #4)
> > > I suppose we should expose ENABLE_XSLT as a public option, since it allows
> > > avoiding a dependency that's not needed on embedded devices.
> > 
> > Yes, I think that makes sense.
> 
> +1

Please do. We want to remove libxslt from WinCairo by default

[Michael Catanzaro]

This doesn't affect WinCairo at all since the choice of which options to expose for WPE is WPE-specific.

[Michael Catanzaro]

Bug #177857

[Michael Catanzaro]

In the future: please no patches to allow disabling dependencies unless the corresponding feature flag also made public.