[Settings] Move remaining simple settings to Settings.in
Created attachment 322341 [details]
Created attachment 322350 [details]
Created attachment 322351 [details]
The commit-queue encountered the following flaky tests while processing attachment 322351 [details]:
The commit-queue is continuing to process your patch.
Comment on attachment 322351 [details]
Clearing flags on attachment: 322351
Committed r222698: <http://trac.webkit.org/changeset/222698>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by bug 177835
Created attachment 324131 [details]
Created attachment 324134 [details]
Comment on attachment 324134 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=324134&action=review
> + Migrage simple settings from SettingsBase to here.
No need to rage about it.
Migrage => Migrate
> + if self.getter:
> + return self.getter
> return self.name
return self.getter or self.name
> + for line in open(input, 'r'):
This is leaking the file handle. It is good programming practice to close the file once we no longer need it. Either we need a close() or, we can use the "with" keyword since File objects implement the context manager interface:
with open(input, 'r') as file:
for line in file:
See <https://docs.python.org/2/tutorial/inputoutput.html> for more details.
Created attachment 324137 [details]
Comment on attachment 324137 [details]
Clearing flags on attachment: 324137
Committed r223624: <https://trac.webkit.org/changeset/223624>