Bug 177727 - [Settings] Enums should not be passed by const reference
Summary: [Settings] Enums should not be passed by const reference
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on: 177835
Blocks:
  Show dependency tree / graph
 
Reported: 2017-10-01 15:38 PDT by Sam Weinig
Modified: 2017-10-18 12:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.45 KB, patch)
2017-10-01 15:54 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-10-01 15:38:49 PDT 
[Settings] Enums should not be passed by const reference
Comment 1 Sam Weinig 2017-10-01 15:54:33 PDT 
Created attachment 322336 [details]
Patch
Comment 2 WebKit Commit Bot 2017-10-01 20:17:22 PDT 
Comment on attachment 322336 [details]
Patch

Clearing flags on attachment: 322336

Committed r222695: <http://trac.webkit.org/changeset/222695>
Comment 3 WebKit Commit Bot 2017-10-01 20:17:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-10-01 20:18:42 PDT 
<rdar://problem/34762536>
Comment 5 WebKit Commit Bot 2017-10-03 13:46:14 PDT 
Re-opened since this is blocked by bug 177835
Comment 6 Sam Weinig 2017-10-18 12:44:57 PDT 
Re-fixed this in a different bug.