Bug 177726 - Create a SPIR-V assembler
Summary: Create a SPIR-V assembler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2017-10-01 14:44 PDT by Myles C. Maxfield
Modified: 2018-10-13 19:21 PDT (History)
6 users (show)

See Also:

Attachments
WIP (179.53 KB, patch)
2017-10-01 14:45 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (185.03 KB, patch)
2017-10-02 12:12 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (187.84 KB, patch)
2017-10-02 23:26 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (189.02 KB, patch)
2017-10-03 10:34 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (187.37 KB, patch)
2017-10-03 13:58 PDT, Myles C. Maxfield 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-10-01 14:44:56 PDT 
Create a SPIR-V assembler
Comment 1 Myles C. Maxfield 2017-10-01 14:45:45 PDT 
Created attachment 322335 [details]
WIP

WIP
Comment 2 Myles C. Maxfield 2017-10-02 12:12:35 PDT 
Created attachment 322408 [details]
Patch

Patch
Comment 3 Myles C. Maxfield 2017-10-02 23:26:11 PDT 
Created attachment 322493 [details]
Patch
Comment 4 Sam Weinig 2017-10-03 07:09:21 PDT 
Comment on attachment 322493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322493&action=review

> Tools/WebGPUShadingLanguageRI/SPIR-V.js:30
> +    var xhr = new XMLHttpRequest();
> +    xhr.addEventListener("load", function () {
> +        let json = JSON.parse(this.responseText);

This can be made a bit more modern by either using fetch() with response.json (which I would recommend) or by continuing to use XHR and using xhr.responseType = "json".
Comment 5 Myles C. Maxfield 2017-10-03 10:34:15 PDT 
Created attachment 322543 [details]
WIP
Comment 6 Myles C. Maxfield 2017-10-03 13:58:04 PDT 
Created attachment 322576 [details]
Patch

Patch
Comment 7 Filip Pizlo 2017-10-03 17:36:22 PDT 
Comment on attachment 322576 [details]
Patch

rs=me
Comment 8 Myles C. Maxfield 2017-10-03 17:53:39 PDT 
Committed r222825: <http://trac.webkit.org/changeset/222825>
Comment 9 Radar WebKit Bug Importer 2017-10-03 17:54:08 PDT 
<rdar://problem/34803955>
Comment 10 Myles C. Maxfield 2018-10-13 19:21:53 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/167