Bug 177704 - WSL should be fine with &foo()[i] if foo() returns a []
Summary: WSL should be fine with &foo()[i] if foo() returns a []
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2017-09-29 23:35 PDT by Filip Pizlo
Modified: 2018-10-13 19:23 PDT (History)
3 users (show)

See Also:

Attachments
the patch (11.99 KB, patch)
2017-09-30 00:28 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-09-29 23:35:45 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-09-30 00:28:48 PDT 
Created attachment 322285 [details]
the patch
Comment 2 Filip Pizlo 2017-09-30 00:30:54 PDT 
Comment on attachment 322285 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322285&action=review

> Tools/WebGPUShadingLanguageRI/Checker.js:492
> +            node.notLValueReason = "Base of property access is neither lvalue not array reference";

*nor
Comment 3 Saam Barati 2017-10-02 14:50:42 PDT 
Comment on attachment 322285 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322285&action=review

> Tools/WebGPUShadingLanguageRI/PropertyAccessExpression.js:32
> +        this._isLValue = null; // We use null to indicate that we don't know yet.

Do you use this fact somewhere?
Comment 4 Filip Pizlo 2017-10-02 15:01:17 PDT 
Landed in https://trac.webkit.org/changeset/222750/webkit
Comment 5 Radar WebKit Bug Importer 2017-10-02 15:02:50 PDT 
<rdar://problem/34777663>
Comment 6 Myles C. Maxfield 2018-10-13 19:23:59 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/169