Bug 177643 – Make WSL demo compatible with Microsoft Edge

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Myles C. Maxfield]

Make WSL demo compatible with Microsoft Edge

[Myles C. Maxfield]

Created attachment 322169 [details]
Patch

[Saam Barati]

Comment on attachment 322169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322169&action=review

> Tools/ChangeLog:7
> +        because Microsoft Edge throws an exception when trying to use a for...of loop with it. This patch also hides

Do you know why they throw? Is it just an engine bug on their end?

[WebKit Commit Bot]

Comment on attachment 322169 [details]
Patch

Rejecting attachment 322169 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 322169, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/4696196

[Myles C. Maxfield]

(In reply to Saam Barati from comment #2)
> Comment on attachment 322169 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322169&action=review
> 
> > Tools/ChangeLog:7
> > +        because Microsoft Edge throws an exception when trying to use a for...of loop with it. This patch also hides
> 
> Do you know why they throw? Is it just an engine bug on their end?

Looks like it's a bug in our own engine because it looks like it's not supposed to work out of the box (and it works out of the box on WebKit). https://stackoverflow.com/questions/22754315/for-loop-for-htmlcollection-elements#answer-22754453 says:

Update for ES6 in 2016
You can now use the ES6 for/of construct with a NodeList and an HTMLCollection by just adding this to your code:
NodeList.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator];
HTMLCollection.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator];

[Myles C. Maxfield]

(In reply to Myles C. Maxfield from comment #4)
> (In reply to Saam Barati from comment #2)
> > Comment on attachment 322169 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=322169&action=review
> > 
> > > Tools/ChangeLog:7
> > > +        because Microsoft Edge throws an exception when trying to use a for...of loop with it. This patch also hides
> > 
> > Do you know why they throw? Is it just an engine bug on their end?
> 
> Looks like it's a bug in our own engine because it looks like it's not
> supposed to work out of the box (and it works out of the box on WebKit).
> https://stackoverflow.com/questions/22754315/for-loop-for-htmlcollection-
> elements#answer-22754453 says:
> 
> Update for ES6 in 2016
> You can now use the ES6 for/of construct with a NodeList and an
> HTMLCollection by just adding this to your code:
> NodeList.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator];
> HTMLCollection.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator];

Wait, scratch that - I didn't read far enough in the answer. Seems that Edge just hasn't caught up yet to the rest of the browsers.

[Myles C. Maxfield]

Committed r222770: <http://trac.webkit.org/changeset/222770>

[Radar WebKit Bug Importer]

<rdar://problem/34785032>

[Myles C. Maxfield]

Migrated to https://github.com/gpuweb/WHLSL/issues/171