Bug 177634 - REGRESSION(r222640) [GTK] Build broken with ATK 2.14
Summary: REGRESSION(r222640) [GTK] Build broken with ATK 2.14
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joanmarie Diggs (irc: joanie)
URL:
Keywords:
Depends on:
Blocks: 177542
  Show dependency treegraph
 
Reported: 2017-09-28 18:32 PDT by Carlos Alberto Lopez Perez
Modified: 2017-10-02 05:17 PDT (History)
11 users (show)

See Also:


Attachments
Patch (1.48 KB, patch)
2017-10-02 02:43 PDT, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-09-28 18:32:24 PDT
It seems ATK_STATE_READ_ONLY Requires ATK >= 2.16

And Debian 8 still ships 2.14, and per our dependencies policy https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy we still should support the default build there.

Build log failure:
https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/5902/steps/compile-webkit/logs/stdio

Its not needed to make the feature work with ATK 2.14.
We only need to fix the build, so building WebKitGTK+ on Debian 8 (Jessie) can continue to be possible. 

Therefore just #ifdef'ing the code for ATK >= 2.16 is ok.
Comment 1 Joanmarie Diggs (irc: joanie) 2017-10-02 02:43:38 PDT
Created attachment 322366 [details]
Patch
Comment 2 WebKit Commit Bot 2017-10-02 05:17:27 PDT
Comment on attachment 322366 [details]
Patch

Clearing flags on attachment: 322366

Committed r222705: <http://trac.webkit.org/changeset/222705>
Comment 3 WebKit Commit Bot 2017-10-02 05:17:29 PDT
All reviewed patches have been landed.  Closing bug.