WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
177634
REGRESSION(
r222640
) [GTK] Build broken with ATK 2.14
https://bugs.webkit.org/show_bug.cgi?id=177634
Summary
REGRESSION(r222640) [GTK] Build broken with ATK 2.14
Carlos Alberto Lopez Perez
Reported
2017-09-28 18:32:24 PDT
It seems ATK_STATE_READ_ONLY Requires ATK >= 2.16 And Debian 8 still ships 2.14, and per our dependencies policy
https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy
we still should support the default build there. Build log failure:
https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/5902/steps/compile-webkit/logs/stdio
Its not needed to make the feature work with ATK 2.14. We only need to fix the build, so building WebKitGTK+ on Debian 8 (Jessie) can continue to be possible. Therefore just #ifdef'ing the code for ATK >= 2.16 is ok.
Attachments
Patch
(1.48 KB, patch)
2017-10-02 02:43 PDT
,
Joanmarie Diggs
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joanmarie Diggs
Comment 1
2017-10-02 02:43:38 PDT
Created
attachment 322366
[details]
Patch
WebKit Commit Bot
Comment 2
2017-10-02 05:17:27 PDT
Comment on
attachment 322366
[details]
Patch Clearing flags on attachment: 322366 Committed
r222705
: <
http://trac.webkit.org/changeset/222705
>
WebKit Commit Bot
Comment 3
2017-10-02 05:17:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug