Bug 177542 - AX: [ATK] object:state-changed notifications missing for multiple ARIA attributes
Summary: AX: [ATK] object:state-changed notifications missing for multiple ARIA attrib...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All Linux
: P2 Normal
Assignee: Joanmarie Diggs (irc: joanie)
URL:
Keywords: InRadar
Depends on: 177634
Blocks:
  Show dependency treegraph
 
Reported: 2017-09-27 08:47 PDT by Joanmarie Diggs (irc: joanie)
Modified: 2017-09-28 18:32 PDT (History)
9 users (show)

See Also:


Attachments
Patch (22.64 KB, patch)
2017-09-27 11:43 PDT, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff
Patch (22.68 KB, patch)
2017-09-28 15:42 PDT, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs (irc: joanie) 2017-09-27 08:47:00 PDT
When the following ARIA attributes have value changes, an object:state-changed notification is expected but currently not emitted:

* aria-disabled
* aria-expanded
* aria-pressed
* aria-readonly
* aria-required
Comment 1 Radar WebKit Bug Importer 2017-09-27 08:47:27 PDT
<rdar://problem/34686677>
Comment 2 Joanmarie Diggs (irc: joanie) 2017-09-27 11:43:41 PDT
Created attachment 321985 [details]
Patch
Comment 3 Joanmarie Diggs (irc: joanie) 2017-09-27 13:58:13 PDT
Comment on attachment 321985 [details]
Patch

Chris: Please review. Thanks!
Comment 4 chris fleizach 2017-09-28 15:03:24 PDT
Comment on attachment 321985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321985&action=review

> Source/WebCore/accessibility/AXObjectCache.h:288
> +        AXPressedChanged,

Can we call this PressedState (it seems similar to DisabledState)

> Source/WebCore/accessibility/AXObjectCache.h:289
> +        AXReadOnlyChanged,

ReadOnlyStatus

> Source/WebCore/accessibility/AXObjectCache.h:290
> +        AXRequiredChanged,

RequiredStatus
Comment 5 Joanmarie Diggs (irc: joanie) 2017-09-28 15:42:45 PDT
Created attachment 322130 [details]
Patch
Comment 6 WebKit Commit Bot 2017-09-28 17:13:17 PDT
Comment on attachment 322130 [details]
Patch

Clearing flags on attachment: 322130

Committed r222640: <http://trac.webkit.org/changeset/222640>
Comment 7 WebKit Commit Bot 2017-09-28 17:13:18 PDT
All reviewed patches have been landed.  Closing bug.