Bug 177569 - Sync SYSTEM_MALLOC implementation of Gigacage
Summary: Sync SYSTEM_MALLOC implementation of Gigacage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-27 14:45 PDT by Don Olmstead
Modified: 2017-09-28 10:37 PDT (History)
12 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2017-09-27 14:47 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2017-09-27 18:41 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-09-27 14:45:05 PDT 
The interface of Gigacage was changed in https://bugs.webkit.org/show_bug.cgi?id=174972 but the SYSTEM_MALLOC implementation in WTF was not updated.
Comment 1 Don Olmstead 2017-09-27 14:47:08 PDT 
Created attachment 322018 [details]
Patch

Putting up for review to make sure this is the correct fix
Comment 2 Don Olmstead 2017-09-27 14:49:45 PDT 
This should fix the WinCairo build which is x64 https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/6661/steps/compile-webkit/logs/stdio
Comment 3 Don Olmstead 2017-09-27 18:41:21 PDT 
Created attachment 322052 [details]
Patch

Rebasing after https://bugs.webkit.org/show_bug.cgi?id=177565
Comment 4 Radar WebKit Bug Importer 2017-09-28 07:58:07 PDT 
<rdar://problem/34713975>
Comment 5 Mark Lam 2017-09-28 10:02:17 PDT 
Comment on attachment 322052 [details]
Patch

r=me if this has been tested to work.  Is it tested?
Comment 6 Don Olmstead 2017-09-28 10:10:07 PDT 
Comment on attachment 322052 [details]
Patch

It was building and running locally for me.
Comment 7 WebKit Commit Bot 2017-09-28 10:37:37 PDT 
Comment on attachment 322052 [details]
Patch

Clearing flags on attachment: 322052

Committed r222615: <http://trac.webkit.org/changeset/222615>
Comment 8 WebKit Commit Bot 2017-09-28 10:37:40 PDT 
All reviewed patches have been landed.  Closing bug.