Bug 174972 - Put g_gigacageBasePtr into its own page and make it read-only
Summary: Put g_gigacageBasePtr into its own page and make it read-only
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 174917
  Show dependency tree / graph
 
Reported: 2017-07-29 12:16 PDT by Filip Pizlo
Modified: 2017-09-27 12:50 PDT (History)
8 users (show)

See Also:

Attachments
the patch (13.43 KB, patch)
2017-09-26 17:27 PDT, Filip Pizlo 		msaboff: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-elcapitan (2.03 MB, application/zip)
2017-09-26 19:02 PDT, Build Bot 		no flags Details
the patch (13.50 KB, patch)
2017-09-26 20:54 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-07-29 12:16:42 PDT 
...
Comment 1 Filip Pizlo 2017-09-26 17:27:18 PDT 
Created attachment 321904 [details]
the patch
Comment 2 Build Bot 2017-09-26 17:29:29 PDT 
Attachment 321904 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Gigacage.cpp:36:  g_gigacageBasePtrs is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Saboff 2017-09-26 18:13:26 PDT 
Comment on attachment 321904 [details]
the patch

r=me
Comment 4 Build Bot 2017-09-26 19:02:10 PDT 
Comment on attachment 321904 [details]
the patch

Attachment 321904 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4671498

New failing tests:
compositing/contents-format/subpixel-antialiased-text-configs.html
compositing/canvas/accelerated-canvas-compositing.html
compositing/canvas/accelerated-canvas-compositing-size-limit.html
accessibility/mac/abbr-acronym-tags.html
compositing/clipping/border-radius-overflow-hidden-stacking-context.html
compositing/contents-opaque/background-clip.html
compositing/culling/clear-fixed-iframe.html
compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html
accessibility/text-marker/character-offset-visible-position-conversion-hang.html
compositing/animation/animated-composited-inside-hidden.html
compositing/culling/filter-occlusion-alpha.html
compositing/culling/filter-occlusion-alpha-large.html
accessibility/mac/value-change/value-change-user-info-contenteditable.html
animations/CSSKeyframesRule-name-null.html
compositing/absolute-inside-out-of-view-fixed.html
compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html
Comment 5 Build Bot 2017-09-26 19:02:12 PDT 
Created attachment 321926 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Filip Pizlo 2017-09-26 20:54:03 PDT 
Created attachment 321936 [details]
the patch
Comment 7 Build Bot 2017-09-26 20:55:31 PDT 
Attachment 321936 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Gigacage.cpp:36:  g_gigacageBasePtrs is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Filip Pizlo 2017-09-26 21:03:58 PDT 
Comment on attachment 321936 [details]
the patch

Clear r? because this patch is already reviewed.
Comment 9 Filip Pizlo 2017-09-26 22:05:50 PDT 
Landed in https://trac.webkit.org/changeset/222549/webkit
Comment 10 Radar WebKit Bug Importer 2017-09-27 12:50:19 PDT 
<rdar://problem/34694112>