Bug 177393 - REGRESSION(r221632): Re-enable configuration.HTTPCookieStorage on session without credentials
Summary: REGRESSION(r221632): Re-enable configuration.HTTPCookieStorage on session wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
: 177809 (view as bug list)
Depends on:
Blocks: 177452
  Show dependency tree / graph
 
Reported: 2017-09-22 15:34 PDT by John Wilander
Modified: 2017-10-04 09:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2017-09-22 15:47 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2017-09-22 15:34:14 PDT 
The following setting on m_statelessSession (used to be m_sessionWithoutCredentialStorage) caused regressions on a number of sites:
configuration.HTTPCookieStorage = nil;
configuration.HTTPCookieAcceptPolicy = NSHTTPCookieAcceptPolicyNever;

We should re-enable the cookie jar until we've figured out the cause of the regression.
Comment 1 John Wilander 2017-09-22 15:36:03 PDT 
Follow-up investigation to be handled in https://bugs.webkit.org/show_bug.cgi?id=177394.
Comment 2 Radar WebKit Bug Importer 2017-09-22 15:43:53 PDT 
<rdar://problem/34604929>
Comment 3 John Wilander 2017-09-22 15:47:50 PDT 
Created attachment 321597 [details]
Patch
Comment 4 Brent Fulgham 2017-09-22 16:09:01 PDT 
Comment on attachment 321597 [details]
Patch

r=me
Comment 5 John Wilander 2017-09-22 16:09:50 PDT 
Comment on attachment 321597 [details]
Patch

Thanks, Brent!
Comment 6 WebKit Commit Bot 2017-09-22 16:37:27 PDT 
Comment on attachment 321597 [details]
Patch

Clearing flags on attachment: 321597

Committed r222414: <http://trac.webkit.org/changeset/222414>
Comment 7 WebKit Commit Bot 2017-09-22 16:37:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 John Wilander 2017-10-04 09:41:44 PDT 
*** Bug 177809 has been marked as a duplicate of this bug. ***