eventInitDict parameter to GamepadEvent constructor should be optional to match Firefox and Chrome.
Per Web IDL: """ If the type of an argument is a dictionary type (or a union type that has a dictionary as one of its flattened member types), and that dictionary type and its ancestors have no required members, and the argument is either the final argument or is followed only by optional arguments, then the argument must be specified as optional. Such arguments are always considered to have a default value of an empty dictionary, unless otherwise specified. """
Created attachment 321443 [details] Patch
Spec at https://w3c.github.io/gamepad/#gamepadevent-interface is wrong, see https://github.com/w3c/gamepad/issues/35
Comment on attachment 321443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321443&action=review > Source/WebCore/ChangeLog:9 > + and Chrome. Having such dictionary parameter is also not valid Web IDL: Can you make this an error in the generator?
Comment on attachment 321443 [details] Patch Clearing flags on attachment: 321443 Committed r222348: <http://trac.webkit.org/changeset/222348>
All reviewed patches have been landed. Closing bug.
Comment on attachment 321443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321443&action=review >> Source/WebCore/ChangeLog:9 >> + and Chrome. Having such dictionary parameter is also not valid Web IDL: > > Can you make this an error in the generator? Heh, I came here to ask the same question.
(In reply to Darin Adler from comment #7) > Comment on attachment 321443 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321443&action=review > > >> Source/WebCore/ChangeLog:9 > >> + and Chrome. Having such dictionary parameter is also not valid Web IDL: > > > > Can you make this an error in the generator? > > Heh, I came here to ask the same question. Yes, will take a look once I am done with some urgent tasks.
<rdar://problem/34693049>