Bug 154246 – Use high resolution timestamp for event time

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Simon Fraser (smfr)]

We should consider switching the timestamp we use for events, per:

https://developers.google.com/web/updates/2016/01/high-res-timestamps
https://github.com/whatwg/dom/issues/23

[Simon Fraser (smfr)]

Seems like we should hold off on this until the issues discussed in https://github.com/whatwg/dom/issues/23 have been resolved.

[Ryosuke Niwa]

There are multiple stack overflow posting about this behavior in Chrome:
http://stackoverflow.com/questions/34323019/jquery-javascript-event-timestamp-doesnt-work

A pattern of code that uses Event.prototype.timeStamp for `setTime` appears in various cookbooks:
https://github.com/andygnewman/javascript-jquery-book/blob/2de6e8b0b4755c257675d5d00300f17e3e0c26fa/c07/js/event-object.js

[Majid Valipour]

Here is some update on this feature:

High resolution event timestamps has been shipped in Chrome since M49[1] (released March 2016) and in Firefox stable since M54 [2] (released June 2017) and in Microsoft Edge Since EdgeHTML 14 [3].  WHATWG DOM spec has been updated [4] to reflect this with appropriate tests upstreamed to web-platform-tests.

Also we have received very positive feedback from Facebook [5] about the usefulness of high resolution event timestamp in scroll performance investigations.

I think at this point it is pretty safe to make the conversion given that it has been shipping for a while in 3 major browsers and our experience so far has been that backward compatibility issues are reasonably small and manageable.



[1] https://www.chromestatus.com/feature/5523910145605632
[2] https://developer.mozilla.org/en-US/Firefox/Releases/54
[3] https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12726672/
[4] https://dom.spec.whatwg.org/#dom-event-timestamp
[5] https://github.com/whatwg/dom/issues/23#issuecomment-249319401

[Radar WebKit Bug Importer]

<rdar://problem/34333304>

[Chris Dumez]

Test: http://w3c-test.org/dom/events/Event-timestamp-high-resolution.html

[Majid Valipour]

And also: http://w3c-test.org/dom/events/Event-timestamp-safe-resolution.html

[Chris Dumez]

Created attachment 321348 [details]
WIP Patch

[Chris Dumez]

Created attachment 321384 [details]
WIP Patch

[Chris Dumez]

Created attachment 321385 [details]
WIP Patch

[Build Bot]

Attachment 321385 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Event.cpp:229:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/html/TypeAhead.h:28:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321387 [details]
WIP Patch

[Build Bot]

Attachment 321387 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 56 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321388 [details]
WIP Patch

[Build Bot]

Attachment 321388 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321390 [details]
WIP Patch

[Build Bot]

Attachment 321390 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 8 in 59 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321430 [details]
WIP Patch

[Build Bot]

Attachment 321430 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 8 in 61 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321432 [details]
WIP Patch

[Build Bot]

Attachment 321432 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 9 in 64 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321433 [details]
WIP Patch

[Build Bot]

Attachment 321433 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 9 in 64 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321435 [details]
WIP Patch

[Build Bot]

Attachment 321435 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 9 in 65 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321437 [details]
Patch

[Chris Dumez]

Created attachment 321440 [details]
Patch

[Build Bot]

Attachment 321440 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 9 in 71 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321458 [details]
Patch

[Build Bot]

Attachment 321458 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 9 in 75 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321462 [details]
Patch

[Build Bot]

Attachment 321462 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 9 in 76 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321463 [details]
Patch

[Build Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Build Bot]

Attachment 321463 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp"
Total errors found: 9 in 77 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321466 [details]
Patch

[Build Bot]

Attachment 321466 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp"
Total errors found: 9 in 78 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321473 [details]
Patch

[Build Bot]

Attachment 321473 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp"
Total errors found: 9 in 79 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321474 [details]
Patch

[Build Bot]

Attachment 321474 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp"
Total errors found: 9 in 79 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 321474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321474&action=review

> LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-timestamp-high-resolution-expected.txt:2
> +PASS Constructed MouseEvent timestamp should be high resolution and have the same time origin as performance.now() 

In performance.now we explicitly call reduceTimeResolution to prevent nanosecond time from being available to JavaScript.  I see no such thing in this patch.

[Ryosuke Niwa]

Comment on attachment 321474 [details]
Patch

Yeah, we need to call reduceTimeResolution everywhere. r- because this introduces a new timing attack vulnerability.

[Chris Dumez]

Comment on attachment 321474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321474&action=review

> Source/WebCore/page/Performance.cpp:88
> +    return reduceTimeResolution(seconds).milliseconds();

The reduceTimeResolution() call is here...

[Chris Dumez]

(In reply to Chris Dumez from comment #43)
> Comment on attachment 321474 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321474&action=review
> 
> > Source/WebCore/page/Performance.cpp:88
> > +    return reduceTimeResolution(seconds).milliseconds();
> 
> The reduceTimeResolution() call is here...

And this is covered by imported/w3c/web-platform-tests/dom/events/Event-timestamp-safe-resolution.html which still passes after my change.

[Ryosuke Niwa]

Comment on attachment 321474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321474&action=review

> Source/WebCore/page/Performance.cpp:85
> +DOMHighResTimeStamp Performance::monotonicTimeToHighResTimeStamp(MonotonicTime timestamp) const

I don't think converts MonotonicTime to DOMHighResTimeStamp is the most interesting aspect of this function.
I'd rather focus on the fact this computes time relative to the time origin and that it reduces the resolution is more interesting & important information to communicate.
So why don't we call this something like relativeTimeFromTimeOriginInReducedResolution?

[Chris Dumez]

Created attachment 321551 [details]
Patch

[Build Bot]

Attachment 321551 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/PlatformMouseEvent.h:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/mac/NativeWebGestureEventMac.mm:66:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKit/Shared/gtk/WebEventFactory.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:45:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebKitLegacy/mac/WebView/WebFrame.mm:967:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp"
Total errors found: 9 in 79 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 321556 [details]
Patch

[Chris Dumez]

Comment on attachment 321556 [details]
Patch

Clearing flags on attachment: 321556

Committed r222392: <http://trac.webkit.org/changeset/222392>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

This caused bug #177444, bug #177447, and bug #177449. I won't roll it out, but if you could check and see if anything looks immediately suspicious, that would be great.

[Chris Dumez]

(In reply to Michael Catanzaro from comment #51)
> This caused bug #177444, bug #177447, and bug #177449. I won't roll it out,
> but if you could check and see if anything looks immediately suspicious,
> that would be great.

One of them is expected. The 2 others may indicate something wrong with my patch but in GTK-specific code (since it did not cause any failures on Mac / iOS). I'll take a look at the GTK parts in this patch to see if I find what I did wrong.

[Michael Catanzaro]

By the way, thanks a bunch for trying to update our ports!

[Chris Dumez]

*** Bug 94987 has been marked as a duplicate of this bug. ***