Bug 177287 - Web Inspector: Remove support for CSS Regions
Summary: Web Inspector: Remove support for CSS Regions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks: 174978
  Show dependency tree / graph
 
Reported: 2017-09-20 18:56 PDT by Joseph Pecoraro
Modified: 2017-09-27 12:19 PDT (History)
13 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (103.87 KB, patch)
2017-09-21 13:24 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (105.68 KB, patch)
2017-09-21 13:31 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-09-20 18:56:31 PDT 
Remove support for CSS Regions.

Part of the overall:
<https://webkit.org/b/174978> Remove support for CSS regions

CSS Domain:

    "id": "Region",
    "id": "NamedFlow",
    "name": "getNamedFlowCollection",
    "namedFlowCreated",
    "namedFlowRemoved",
    "regionOversetChanged",
    "registeredNamedFlowContentElement",
    "unregisteredNamedFlowContentElement",

And related Frontend handling of Regions.

Note:
- We MUST leave in the observer points at the least.
- Maybe leave stuff in so older backends still have something to show? Probably not though.
Comment 1 Joseph Pecoraro 2017-09-21 11:49:25 PDT 
As others have pointed out, we should remove associated tests as well.
Comment 2 Joseph Pecoraro 2017-09-21 13:24:59 PDT 
Created attachment 321471 [details]
[PATCH] Proposed Fix
Comment 3 Build Bot 2017-09-21 13:27:58 PDT 
Attachment 321471 [details] did not pass style-queue:


ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/TestExpectations:1506:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1778:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1779:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1780:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1781:  Path does not exist.  [test/expectations] [5]
Total errors found: 5 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Joseph Pecoraro 2017-09-21 13:31:47 PDT 
Created attachment 321472 [details]
[PATCH] Proposed Fix
Comment 5 Matt Baker 2017-09-21 14:09:47 PDT 
Comment on attachment 321472 [details]
[PATCH] Proposed Fix

r=me
Comment 6 WebKit Commit Bot 2017-09-21 15:32:53 PDT 
Comment on attachment 321472 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 321472

Committed r222356: <http://trac.webkit.org/changeset/222356>
Comment 7 WebKit Commit Bot 2017-09-21 15:32:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:19:19 PDT 
<rdar://problem/34693031>