Bug 174978 – Remove support for CSS regions

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Andreas Kling]

I think the time has come to remove CSS regions.
We are the only remaining engine that supports them unprefixed, and the maintenance cost is too high to justify.

[Andreas Kling]

https://lists.webkit.org/pipermail/webkit-dev/2017-July/029315.html

[Andreas Kling]

Created attachment 316840 [details]
Patch for EWS

Let's start with style, DOM and layout tests. Ripping out the stuff in rendering will require a bit more care.

[Andreas Kling]

Created attachment 316842 [details]
Patch for EWS

[Andreas Kling]

Created attachment 316869 [details]
Patch for EWS

[Andreas Kling]

Created attachment 316876 [details]
Patch for EWS

[Build Bot]

Attachment 316876 [details] did not pass style-queue:


ERROR: Source/WebCore/style/RenderTreePosition.cpp:108:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios/TestExpectations:1538:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-simulator-wk1/TestExpectations:8:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1164:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:2807:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:3114:  More specific entry for accessibility/heading-crash-after-hidden.html on line LayoutTests/platform/win/TestExpectations:3114 overrides line LayoutTests/platform/win/TestExpectations:1349.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:3772:  More specific entry for http/tests/websocket/tests/hybi/workers/close-code-and-reason.html on line LayoutTests/platform/win/TestExpectations:3772 overrides line LayoutTests/platform/win/TestExpectations:2159.  [test/expectations] [5]
Total errors found: 7 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 316876 [details]
Patch for EWS

Attachment 316876 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4236093

New failing tests:
fast/dom/collection-iterators.html

[Build Bot]

Created attachment 316904 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Build Bot]

Comment on attachment 316876 [details]
Patch for EWS

Attachment 316876 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4236104

New failing tests:
fast/dom/collection-iterators.html

[Build Bot]

Created attachment 316905 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Build Bot]

Comment on attachment 316876 [details]
Patch for EWS

Attachment 316876 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4237137

New failing tests:
fast/dom/StyleSheet/detached-sheet-owner-node-link.html

[Build Bot]

Created attachment 316924 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Andreas Kling]

Created attachment 318121 [details]
Patch for EWS

[Andreas Kling]

Created attachment 318128 [details]
Patch for EWS

[Build Bot]

Attachment 318128 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebCore/style/RenderTreePosition.cpp:108:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios/TestExpectations:1537:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-simulator-wk1/TestExpectations:8:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:2795:  Path does not exist.  [test/expectations] [5]
Total errors found: 9 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Radar WebKit Bug Importer]

<rdar://problem/34541384>