Bug 177273 – REGRESSION(r222194) [WPE] Library and executable output names broken

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Alberto Lopez Perez]

Not sure what caused this but it was something recent.

$ Tools/Scripts/run-minibrowser --wpe 
Can't find built framework at "/home/clopez/webkit/wpe/WebKitBuild/Release/lib/libWPEWebKit.so".


And if I try this patch
--- a/Tools/Scripts/webkitdirs.pm
+++ b/Tools/Scripts/webkitdirs.pm
@@ -959,7 +959,7 @@ sub builtDylibPathForName
         }
     }
     if (isWPE()) {
-        return "$configurationProductDir/lib/libWPEWebKit.so";
+        return "$configurationProductDir/lib/libWebKit.so";
     }
 
     die "Unsupported platform, can't determine built library locations.\nTry `build-webkit --help` for more information.\n";



Then i get:

$ Tools/Scripts/run-minibrowser --wpe 
Starting dyz 
lib/wpe.lua:3: libWPEWebKit.so: cannot open shared object file: No such file or directory

[Carlos Alberto Lopez Perez]

This was caused by r222194 <https://trac.webkit.org/r222194>

I reverted it locally, triggered a clean build and now I get libWPEWebKit.so generated correctly and the minibrowser works back as expected.

BTW.. I have just triggered clean builds on the WPE bots, as I suspect they were running all this time using the old libWPEWebKit.so (from <r222194)

[Michael Catanzaro]

Created attachment 321379 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 321379 [details]
Patch

Tested. it works ok.
Thanks!

[WebKit Commit Bot]

Comment on attachment 321379 [details]
Patch

Clearing flags on attachment: 321379

Committed r222296: <http://trac.webkit.org/changeset/222296>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.