Bug 177273 - REGRESSION(r222194) [WPE] Library and executable output names broken
Summary: REGRESSION(r222194) [WPE] Library and executable output names broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 174558
  Show dependency tree / graph
 
Reported: 2017-09-20 14:43 PDT by Carlos Alberto Lopez Perez
Modified: 2017-09-27 12:16 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.67 KB, patch)
2017-09-20 15:10 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-09-20 14:43:50 PDT 
Not sure what caused this but it was something recent.

$ Tools/Scripts/run-minibrowser --wpe 
Can't find built framework at "/home/clopez/webkit/wpe/WebKitBuild/Release/lib/libWPEWebKit.so".


And if I try this patch
--- a/Tools/Scripts/webkitdirs.pm
+++ b/Tools/Scripts/webkitdirs.pm
@@ -959,7 +959,7 @@ sub builtDylibPathForName
         }
     }
     if (isWPE()) {
-        return "$configurationProductDir/lib/libWPEWebKit.so";
+        return "$configurationProductDir/lib/libWebKit.so";
     }
 
     die "Unsupported platform, can't determine built library locations.\nTry `build-webkit --help` for more information.\n";



Then i get:

$ Tools/Scripts/run-minibrowser --wpe 
Starting dyz 
lib/wpe.lua:3: libWPEWebKit.so: cannot open shared object file: No such file or directory
Comment 1 Carlos Alberto Lopez Perez 2017-09-20 14:51:48 PDT 
This was caused by r222194 <https://trac.webkit.org/r222194>

I reverted it locally, triggered a clean build and now I get libWPEWebKit.so generated correctly and the minibrowser works back as expected.

BTW.. I have just triggered clean builds on the WPE bots, as I suspect they were running all this time using the old libWPEWebKit.so (from <r222194)
Comment 2 Michael Catanzaro 2017-09-20 15:10:06 PDT 
Created attachment 321379 [details]
Patch
Comment 3 Carlos Alberto Lopez Perez 2017-09-20 15:35:47 PDT 
Comment on attachment 321379 [details]
Patch

Tested. it works ok.
Thanks!
Comment 4 WebKit Commit Bot 2017-09-20 16:05:27 PDT 
Comment on attachment 321379 [details]
Patch

Clearing flags on attachment: 321379

Committed r222296: <http://trac.webkit.org/changeset/222296>
Comment 5 WebKit Commit Bot 2017-09-20 16:05:30 PDT 
All reviewed patches have been landed.  Closing bug.